Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Inventory & Min Quantity Required allows negative values as well #7454

Closed
Pranshu1902 opened this issue Mar 22, 2024 · 0 comments · Fixed by #7455 or ohcnetwork/care#2005
Closed
Assignees

Comments

@Pranshu1902
Copy link
Contributor

Pranshu1902 commented Mar 22, 2024

Describe the bug
In the Manage Inventory page of facility, user is able to enter negative values resulting in incorrect logs. Also, the Minimum Quantity Required can be set as negative value as well.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://care.ohc.network/facility/317b4eb7-7bc1-4487-a876-fc3380bcdf79/inventory
  2. Click on Manage Inventory
  3. Put some values and set the quantity as -1
  4. Submit the form
  5. See error

Expected behavior
Values less than 0 should be rejected both by the frontend and the backend

Screenshots
Screencast from 2024-03-22 13-14-21.webm

image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Pranshu1902 Pranshu1902 self-assigned this Mar 22, 2024
@github-project-automation github-project-automation bot moved this to Triage in Care Mar 22, 2024
@Pranshu1902 Pranshu1902 changed the title Manage Inventory allows negative values as well Manage Inventory & Min Quantity Required allows negative values as well Mar 22, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in Care Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant