-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in page design- normal and critical log update #7351
Comments
@aparnacoronasafe what account credentials should we use to reproduce the issue I would like to work on this issue plz assign me |
|
@rithviknishad I have worked on it and matched the UI of critical and abnormal with stable log update can I make a pull request now. You added the tag discussion required right any reasons? |
If this issue is not assigned to anyone then I can work on this @aparnacoronasafe ? |
@Anish-Parkhi this has discussion required tag so that's why I didn't make any PR |
@hrit2773 @Anish-Parkhi I've updated the main comment to clarify what needs to be done. It'd be a two-part PR as the latter would require redesigning and UI approval to move forward. A mockup design can be shared on how the new UI looks and needs approval. |
@rithviknishad I have reviewed both the pages and I have figured out reusable components in both pages, should I make a mockup in figma and share it with you, also which page's UI should I refer ? the critical care log or normal log ? |
@Anish-Parkhi the components are already present. Just that those rescript components need to be rewritten in typescript. A mockup is only required for the second PR. |
@rithviknishad okay so I will rewrite the components in typescript and make first PR then I will start with the second PR |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity. |
Sentry Issue: CARE-FE-3BD |
@Anish-Parkhi unassigning due to no activity |
@rithviknishad can you assign me this issue |
Closing as further changes required scoped in issue #8115 |
Is your feature request related to a problem? Please describe.
Critical care log update- https://care.coronasafe.in/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e/daily_rounds/2da792c7-7ff8-4b8f-8e68-1397b7848597
Normal log update: https://care.coronasafe.in/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e/daily-rounds/57ba21bd-e024-4ab0-9362-a9af35f75acc
The design of the pages is very different. Make the design consistent.
Action Items
The text was updated successfully, but these errors were encountered: