Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset save- need to refresh's #7342

Closed
aparnacoronasafe opened this issue Mar 5, 2024 · 24 comments · Fixed by #7654
Closed

Preset save- need to refresh's #7342

aparnacoronasafe opened this issue Mar 5, 2024 · 24 comments · Fixed by #7654
Assignees
Labels

Comments

@aparnacoronasafe
Copy link
Member

Is your feature request related to a problem? Please describe.
Users have the option to save a change made to the preset position right on patient dashboard- live feed. However such update to the preset is only available when the user refreshes the page.

Describe the solution you'd like
When a user updates preset- such updation must be available immediately. The user must not have to refresh the page to access the updated preset.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@KshitijTodkar48
Copy link
Contributor

Hi, I would like to work on this issue, can you please assign it to me?

@rithviknishad rithviknishad moved this from Triage to Up Next in Care Mar 5, 2024
@KshitijTodkar48
Copy link
Contributor

@aparnacoronasafe, how can I get the live feed while developing and testing locally and with what role, can I reach the live feed section?

@KshitijTodkar48
Copy link
Contributor

@rithviknishad, @aparnacoronasafe can you please answer my query?

@rithviknishad
Copy link
Member

You can use the asset "Dev Camera" for testing. It is linked to patient:

https://care.ohc.network/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e/feed

@KshitijTodkar48
Copy link
Contributor

@rithviknishad, I have found the files to make changes in the codebase. But to test the changes, I checked the assets, no asset had live camera feeds working. And could not find the asset with the name "Dev Camera". And the link you shared is showing "Page not found". Am I missing something here?

@thedevildude
Copy link
Contributor

@rithviknishad, I have found the files to make changes in the codebase. But to test the changes, I checked the assets, no asset had live camera feeds working. And could not find the asset with the name "Dev Camera". And the link you shared is showing "Page not found". Am I missing something here?

Try Logging in using "devdistrictadmin" as username and "Coronasafe@123" as password

@KshitijTodkar48
Copy link
Contributor

KshitijTodkar48 commented Mar 14, 2024

@rithviknishad , @thedevildude, I logged in as "devdistrictadmin" as you said and reached the camera feed. But the feed is offline. Also, when I start the project locally, there are no patients that have camera feed available and working.

@rithviknishad
Copy link
Member

rithviknishad commented Mar 16, 2024

As long as you connect your frontend to staging backend, you should be able to access the patient with the dev camera.

Dev Camera could be offline at times. cc: @nihal467 @gigincg

@KshitijTodkar48
Copy link
Contributor

KshitijTodkar48 commented Mar 17, 2024

@rithviknishad, I have the backend running locally, how to connect my local frontend to the backend, because I still cannot see the "Dev Camera" asset and the live feed, what else should I do?

@rithviknishad
Copy link
Member

rithviknishad commented Mar 18, 2024

Check now with the above-mentioned credentials. I've updated the configurations

https://care.ohc.network/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/assets/fd605386-90d5-4e8b-bb82-f62b7349d1d3/configure

@KshitijTodkar48
Copy link
Contributor

KshitijTodkar48 commented Mar 18, 2024

@rithviknishad, Thanks for your help so far.
I've checked the live-feed, it is working. I tried updating the preset values of the live-feed and the updates were immediately available without the need of refreshing the page. I didn't find the described issue. The updated presets are available immediately without the need of refreshing the page.

Copy link

github-actions bot commented Apr 2, 2024

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Apr 2, 2024
@thedevildude
Copy link
Contributor

I'd like to work on this issue if it's still relevant

@KshitijTodkar48
Copy link
Contributor

Go ahead man, I'm not working on it.

@KshitijTodkar48 KshitijTodkar48 removed their assignment Apr 2, 2024
@github-actions github-actions bot removed the stale label Apr 3, 2024
@Ashesh3
Copy link
Member

Ashesh3 commented Apr 3, 2024

@thedevildude could you confirm if the issue is still relevant? After updating a preset - does it reflect immediately or you need to manually refresh the page?

@thedevildude
Copy link
Contributor

@Ashesh3 it does seem to work fine in my case. After updating a preset, I switched to a different preset, and then switched back to the updated preset, the updated preset was as expected without refreshing the page.

@Ashesh3
Copy link
Member

Ashesh3 commented Apr 3, 2024

@aparnacoronasafe could you confirm the same, so we can close the issue?

cc: @nihal467

@KshitijTodkar48
Copy link
Contributor

KshitijTodkar48 commented Apr 3, 2024

Even I didn't find the described issue @Ashesh3, I've mentioned it earlier as well.

@rithviknishad
Copy link
Member

I'm able to replicate the issue, it's pretty straightforward as mentioned in the issue.

@rithviknishad
Copy link
Member

See the attached video, where I try to correct the preset: "Clock" to where the clock is visible. Had to refresh for the preset buttons to know about the new coordinates.

https://www.loom.com/share/44a11f82b1e34c6c8a58116ae1a9fc48?sid=c61559a6-084d-4abd-aeb4-5ca51b7f50b7

@thedevildude
Copy link
Contributor

thedevildude commented Apr 4, 2024

@rithviknishad @Ashesh3 When using devdistrictadmin on staging deployment, the default presets doesn't update for some reason. When we refresh the page, the last location of camera is available however on selecting the same default preset again, we are sent back to old position. The patient presets seems to work fine. Is it supposed to happen?

Live.Care.Feed.-.Update.Preset.Test.mp4

Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Apr 19, 2024
@thedevildude
Copy link
Contributor

I've started working on it, should be ready with a draft PR by Monday

@nihal467
Copy link
Member

@thedevildude Unassigning you from this issue due to inactivity. Feel free to reassign yourself if you are still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants