chores: Fixed responsiveness of the expanded sort dropdown in the patients page #7321

ab1123 · 2024-03-01T22:54:28Z

Proposed Changes

Fixes VIsual Bug: Issue in responsiveness #7317
Fixed the responsiveness for the dropdown of Sort by in Patients Page
Aligned the Export and the sort button in phone view for the Patients Page

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Screenshot

…ients page of care.coronasafe.com

vercel · 2024-03-01T22:54:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 11, 2024 9:00pm

netlify · 2024-03-01T22:54:44Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`60e6a15`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/661e676d3f87620008c41555
😎 Deploy Preview	https://deploy-preview-7321--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/Components/Common/Export.tsx

src/Components/Common/components/ButtonV2.tsx

src/Components/Patient/ManagePatients.tsx

src/Components/Common/components/Menu.tsx

Co-authored-by: Ashesh <[email protected]>

nihal467 · 2024-03-05T16:01:26Z

@ab1123 can we make it full-width / grow to use available space in smaller than desktop sizes?

ab1123 · 2024-03-06T16:16:08Z

@ab1123 can we make it full-width / grow to use available space in smaller than desktop sizes?

Yes sure sir, I will edit the necessary changes

ab1123 · 2024-03-11T21:01:25Z

I have pushed the necessary details and henceforth I request for maintainer's review

rithviknishad · 2024-03-12T02:50:09Z

It is still not full-width on mobile screens

This is what is expected:

rithviknishad · 2024-03-12T02:51:14Z

src/Components/Common/components/ButtonV2.tsx

@@ -102,7 +102,7 @@ const ButtonV2 = ({
 }: ButtonProps) => {
  const className = classNames(
    props.className,
-    "inline-flex h-min cursor-pointer items-center justify-center gap-2 whitespace-pre font-medium outline-offset-1 transition-all duration-200 ease-in-out disabled:cursor-not-allowed disabled:bg-gray-200 disabled:text-gray-500",
+    "inline-flex h-max cursor-pointer items-center justify-center gap-2 whitespace-pre font-medium outline-offset-1 transition-all duration-200 ease-in-out disabled:cursor-not-allowed disabled:bg-gray-200 disabled:text-gray-500",


avoid changing classes of the reusable button component as this would affect the entire platform.

Sure sir. I will implement that

rithviknishad · 2024-03-12T02:52:59Z

src/Components/Patient/ManagePatients.tsx

                />
-              )}
+                <div className="tooltip  ml-4">


Suggested change

<div className="tooltip ml-4">

<div className="tooltip ml-4 flex-1">

rithviknishad · 2024-03-12T02:54:15Z

src/Components/Patient/ManagePatients.tsx

-                      parse: preventDuplicatePatientsDuetoPolicyId,
-                    },
-                  ]}
+            <div className="vs:block sm:flex md:flex">


Suggested change

<div className="vs:block sm:flex md:flex">

<div className="vs:block sm:flex md:flex w-full">

github-actions · 2024-03-22T15:22:57Z

👋 Hi, @ab1123,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2024-03-30T04:13:41Z

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

ab1123 · 2024-03-31T21:44:44Z

@rithviknishad can you please review the latest commit as all the requested change are migrated in the latest commit.

nihal467 · 2024-04-02T10:09:13Z

@ab1123 the switching tab UI is breaking in normal desktop view

ab1123 · 2024-04-05T09:41:29Z

Sure sir, I will make the necessary changes and push a new commit

…care_fe into visual-bugs-patient-sort

ab1123 · 2024-04-15T09:46:59Z

@nihal467 kindly verify the changes made

nihal467 · 2024-04-16T12:56:36Z

@ab1123

move the button to the right side, as it is currently in the staging
don't change the export icon
make the same button behavior as the add patient button in responsive

rithviknishad · 2024-05-06T10:57:31Z

Closing due to inactivity. Feel free to re-open the PR.

chores: Fixed responsiveness of the expanded sort dropdown in the pat…

0642a89

…ients page of care.coronasafe.com

ab1123 requested a review from a team as a code owner March 1, 2024 22:54

vercel bot temporarily deployed to Preview March 1, 2024 22:55 Inactive

nihal467 requested review from Ashesh3 and rithviknishad March 4, 2024 05:28

Ashesh3 reviewed Mar 4, 2024

View reviewed changes

src/Components/Common/Export.tsx Outdated Show resolved Hide resolved

Ashesh3 reviewed Mar 4, 2024

View reviewed changes

src/Components/Common/components/ButtonV2.tsx Outdated Show resolved Hide resolved

Ashesh3 reviewed Mar 4, 2024

View reviewed changes

src/Components/Patient/ManagePatients.tsx Outdated Show resolved Hide resolved

Ashesh3 reviewed Mar 4, 2024

View reviewed changes

src/Components/Patient/ManagePatients.tsx Outdated Show resolved Hide resolved

Ashesh3 approved these changes Mar 4, 2024

View reviewed changes

rithviknishad approved these changes Mar 4, 2024

View reviewed changes

src/Components/Common/components/Menu.tsx Outdated Show resolved Hide resolved

Apply suggestions from code review

0d9c8aa

Co-authored-by: Ashesh <[email protected]>

rithviknishad added the needs testing label Mar 4, 2024

vercel bot temporarily deployed to Preview March 4, 2024 06:54 Inactive

nihal467 added test failed changes required and removed needs testing labels Mar 5, 2024

ab1123 and others added 2 commits March 12, 2024 00:03

fix: Made the sort,export and advance filter button responsive

af3b7a4

Merge branch 'develop' into visual-bugs-patient-sort

6d51406

vercel bot temporarily deployed to Preview March 11, 2024 18:38 Inactive

ab1123 added 2 commits March 12, 2024 02:10

fix: Uniformity in screens smaller than laptop

ded1891

Removed Merge Conflicts

4feccb9

vercel bot temporarily deployed to Preview March 11, 2024 21:00 Inactive

rithviknishad requested changes Mar 12, 2024

View reviewed changes

github-actions bot added the merge conflict pull requests with merge conflict label Mar 22, 2024

github-actions bot added the stale label Mar 30, 2024

fix: Resolved merge conflicts

73db362

github-actions bot removed the stale label Mar 31, 2024

rithviknishad added needs testing and removed test failed changes required merge conflict pull requests with merge conflict labels Apr 1, 2024

Merge branch 'develop' into visual-bugs-patient-sort

b1df93f

nihal467 added test failed and removed needs testing labels Apr 2, 2024

ab1123 and others added 4 commits April 5, 2024 15:11

Merge branch 'develop' into visual-bugs-patient-sort

6369aa5

Merge branch 'coronasafe:develop' into visual-bugs-patient-sort

28edc15

fix: fixed the reviewed changes

37a8876

Merge branch 'visual-bugs-patient-sort' of https://github.com/ab1123/…

681157f

…care_fe into visual-bugs-patient-sort

nihal467 added the needs testing label Apr 16, 2024

Merge branch 'develop' into visual-bugs-patient-sort

60e6a15

nihal467 added changes required test failed and removed needs testing test failed labels Apr 16, 2024

rithviknishad closed this May 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chores: Fixed responsiveness of the expanded sort dropdown in the patients page #7321

chores: Fixed responsiveness of the expanded sort dropdown in the patients page #7321

ab1123 commented Mar 1, 2024

vercel bot commented Mar 1, 2024 •

edited

Loading

netlify bot commented Mar 1, 2024 •

edited

Loading

nihal467 commented Mar 5, 2024 •

edited by rithviknishad

Loading

ab1123 commented Mar 6, 2024

ab1123 commented Mar 11, 2024

rithviknishad commented Mar 12, 2024 •

edited

Loading

rithviknishad Mar 12, 2024

ab1123 Mar 17, 2024

rithviknishad Mar 12, 2024

rithviknishad Mar 12, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 30, 2024

ab1123 commented Mar 31, 2024

nihal467 commented Apr 2, 2024

ab1123 commented Apr 5, 2024

ab1123 commented Apr 15, 2024

nihal467 commented Apr 16, 2024 •

edited

Loading

rithviknishad commented May 6, 2024

	<div className="tooltip ml-4">
	<div className="tooltip ml-4 flex-1">

	<div className="vs:block sm:flex md:flex">
	<div className="vs:block sm:flex md:flex w-full">

chores: Fixed responsiveness of the expanded sort dropdown in the patients page #7321

chores: Fixed responsiveness of the expanded sort dropdown in the patients page #7321

Conversation

ab1123 commented Mar 1, 2024

Proposed Changes

Merge Checklist

Screenshot

vercel bot commented Mar 1, 2024 • edited Loading

netlify bot commented Mar 1, 2024 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

nihal467 commented Mar 5, 2024 • edited by rithviknishad Loading

ab1123 commented Mar 6, 2024

ab1123 commented Mar 11, 2024

rithviknishad commented Mar 12, 2024 • edited Loading

rithviknishad Mar 12, 2024

Choose a reason for hiding this comment

ab1123 Mar 17, 2024

Choose a reason for hiding this comment

rithviknishad Mar 12, 2024

Choose a reason for hiding this comment

rithviknishad Mar 12, 2024

Choose a reason for hiding this comment

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 30, 2024

ab1123 commented Mar 31, 2024

nihal467 commented Apr 2, 2024

ab1123 commented Apr 5, 2024

ab1123 commented Apr 15, 2024

nihal467 commented Apr 16, 2024 • edited Loading

rithviknishad commented May 6, 2024

vercel bot commented Mar 1, 2024 •

edited

Loading

netlify bot commented Mar 1, 2024 •

edited

Loading

nihal467 commented Mar 5, 2024 •

edited by rithviknishad

Loading

rithviknishad commented Mar 12, 2024 •

edited

Loading

nihal467 commented Apr 16, 2024 •

edited

Loading