Rearranged facility home layout #7315
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@aparnacoronasafe feel like there are a lot of white spacing issues occurring, can you look into the UI once again |
@nihal467 whats your screen size? I am on a 13inch mac. This is what I am seeing at 100% screen size I think it is good to go |
|
@aparnacoronasafe I am using 15.6-inch laptop screen as well as 27-inch monitor screen , on both of them, they are having a huge white spacing issue |
|
@nihal467 lets release this and think of iterative improvements in design? |
|
IMO the current staging itself seems to be a better layout than the one in this PR for both resolutions. |
|
@gigincg can you review this |
|
@kshitijv256 Can you update the PR based on the Image Reference in the Issue. Padding for the Picture, and the Alignment of the Buttons. Also, post Screenshots for Mobile, Tab, HD & Full HD Screens. Let's wrap this ASAP. |
|
@kshitijv256 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
|
@gigincg @nihal467 @rithviknishad updated screenshots for different screen sizes |
|
There needs to be a a justify-between between the manage facility and rest of the buttons in desktop view as per the issue ref. image 
|
rithviknishad
removed
question
|
Please refer the ref. screenshot in the issue 
The vertical height of the div containing the buttons is limited to the same height as the facility picture. |
|
Changed as requested @rithviknishad
|
|
Layout and alignments looks good to me, but the Edit image button on hover no longer seems to be present Develop deployment on hover: This branch on hover: |
|
Can we also give the image a |
|
@rithviknishad tooltip shows when you hover on top part of image
|
|
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
|
👋 Hi, @kshitijv256, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
github-actions
bot
removed
merge conflict
| @@ -106,7 +106,7 @@ export const FacilityHome = (props: any) => { | |||
| const editCoverImageTooltip = hasPermissionToEditCoverImage && ( | |||
| <div | |||
| id="facility-coverimage" | |||
| className="absolute right-0 top-0 z-10 flex h-full w-full flex-col items-center justify-center bg-black text-sm text-gray-300 opacity-0 transition-opacity hover:opacity-60 md:h-[88px]" | |||
| className="absolute right-0 top-0 z-10 flex h-full w-full flex-col items-center justify-center rounded-t-lg bg-black text-sm text-gray-300 opacity-0 transition-[opacity] hover:opacity-60 md:h-[88px]" | |||
There was a problem hiding this comment.
@kshitijv256 please double check transistion-[opacity] class
There was a problem hiding this comment.
@khavinshankar
I missed it as I was trying out other transitions there, changed it back to transition-opacity
|
@kshitijv256 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Screenshots
Mobile
Tablet
Laptop 14 inch
24 inch 2K screen