Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in adding new user in users section #7307

Closed
Ashutosh0602 opened this issue Feb 28, 2024 · 14 comments · Fixed by #8940
Closed

Issue in adding new user in users section #7307

Ashutosh0602 opened this issue Feb 28, 2024 · 14 comments · Fixed by #8940
Assignees
Labels

Comments

@Ashutosh0602
Copy link
Contributor

Ashutosh0602 commented Feb 28, 2024

Note

Maintainer Note: The issue was filed a considerable amount of time ago. Ensure that the issue is still relevant before working on solving it.

Before we enter anything in input section of user it is showing user is available in empty string.

Screenshot 2024-02-28 at 7 46 39 PM

There is also some problem with validation of user.

@Ashutosh0602
Copy link
Contributor Author

I would like to work on this please assign me.

@Ashutosh0602
Copy link
Contributor Author

@rithviknishad I solved this issue you can check it once and if there is something wrong you can tell me I will try to solve

Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Mar 29, 2024
@RushiK100
Copy link

I would like to work on this please assign me

@github-actions github-actions bot removed the stale label Apr 1, 2024
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Apr 20, 2024
@nihal467
Copy link
Member

@Ashutosh0602 Unassigning you from this issue due to inactivity. Feel free to reassign yourself if you are still working on it.

@SwanandBhuskute
Copy link
Contributor

I would like to work on this issue!

@bodhish
Copy link
Member

bodhish commented Oct 22, 2024

Nice find @SwanandBhuskute

@SwanandBhuskute
Copy link
Contributor

Image
The same issue is occuring with Password field

Should i solve it too in the same go?

Or I have one suggestion
When we have empty fields (haven't typed anything), we can keep it as normal black text and not red, also without any cross/check marks
and once we start typing, then it will perform as usual as now, like

  • it will become red for some checks, green for some checks etc

This will work for both Username field as well as Password field....

Will work as per suggestions...

@rithviknishad
Copy link
Member

yup, can be done in same issue

@SwanandBhuskute
Copy link
Contributor

So should I try that "keep normal black text" for empty field and then after typing, behave like now (checks, red, green text) ?

I mean i will try
because the issue is resolved, just this will add some improvement

@SwanandBhuskute
Copy link
Contributor

Image
Image

So now, before entering any details , this is how username and password fields will look like

  • black, with circle

and after we start entering it will be as normal as now

Image
Image

Image

should i raise the PR for the same or any more suggestions?

@Jacobjeevan
Copy link
Contributor

@SwanandBhuskute Go ahead and open the PR 👍

@SwanandBhuskute
Copy link
Contributor

I have raised the pr for this issue
pls check
#8940

@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
8 participants