Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bed Management System Redesign #7254

Closed
wants to merge 6 commits into from

Conversation

parthksingh1
Copy link

Proposed Changes

This pull request proposes a redesign of the Bed Management system to improve efficiency within healthcare facilities

Screenshot 2024-02-23 005917

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@parthksingh1 parthksingh1 requested a review from a team as a code owner February 23, 2024 07:30
Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2024 0:17am

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 514d432
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65eda4a1eb260c00089ebb4d
😎 Deploy Preview https://deploy-preview-7254--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with the card-based grid layout like we have on the location management page.
Keeping it identical to the location management page would be ideal.

@rithviknishad
Copy link
Member

Refer: https://github.com/coronasafe/care_fe/blob/develop/src/Components/Facility/LocationManagement.tsx

@parthksingh1
Copy link
Author

Hi @rithviknishad ,Thanks for the reference! I'll review the card-based grid layout on the location management page and aim to maintain it in Bed Managment, Appreciate your input!

Copy link

👋 Hi, @parthksingh1,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Feb 23, 2024
Copy link

github-actions bot commented Mar 2, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 2, 2024
@github-actions github-actions bot removed merge conflict pull requests with merge conflict stale labels Mar 7, 2024
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not showing any beds.
#7369 (comment)

@parthksingh1
Copy link
Author

@rithviknishad PTAL

@rithviknishad
Copy link
Member

rithviknishad commented Mar 11, 2024

This still does not look any close to the location management page and looks almost like how the bed management page is in staging

@rithviknishad
Copy link
Member

@parthksingh1 here is the expected design as mentioned in the issue:

image

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 19, 2024
Copy link

github-actions bot commented Apr 6, 2024

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Enhancement for Bed Management
2 participants