Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the Add button height in skills slideover. #7163

Merged

Conversation

shyamprakash123
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shyamprakash123 shyamprakash123 requested a review from a team as a code owner February 4, 2024 11:28
Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c8657d1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65c36f2d58851b000836e14b
😎 Deploy Preview https://deploy-preview-7163--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Feb 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 11:54am

@Ashesh3
Copy link
Member

Ashesh3 commented Feb 6, 2024

After discussing with Nihal, following changes are to be done on the button:

element.style {
    height: 45px !important;
    width: 74px !important;
    font-size: 16px;
}

The above is to be applied on the button using Tailwind classes.

To be done for:

  • Linked Facilities
  • Linked Skills

image

@nihal467
Copy link
Member

nihal467 commented Feb 6, 2024

@shyamprakash123

@shyamprakash123
Copy link
Contributor Author

@nihal467 I've updated the code according to the requested changes.

cc: @rithviknishad @Ashesh3

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing labels Feb 13, 2024
@khavinshankar khavinshankar merged commit ba0b192 into ohcnetwork:develop Feb 14, 2024
36 checks passed
Copy link

@shyamprakash123 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the Add button height in skills slideover
5 participants