Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes undefined shown in Doctor Notes for Nurse user types #7020

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 12, 2024

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 76db601
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65a14c9b2507de0008288991
😎 Deploy Preview https://deploy-preview-7020--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 2:28pm

@rithviknishad rithviknishad marked this pull request as ready for review January 12, 2024 14:28
@rithviknishad rithviknishad requested a review from a team as a code owner January 12, 2024 14:28
@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Jan 12, 2024
Copy link

cypress bot commented Jan 12, 2024

Passing run #1876 ↗︎

0 98 0 0 Flakiness 0

Details:

Fixes `undefined` shown in Doctor Notes for Nurse user types
Project: CARE Commit: 76db6019ed
Status: Passed Duration: 02:19 💡
Started: Jan 12, 2024 2:32 PM Ended: Jan 12, 2024 2:34 PM

Review all test suite changes for PR #7020 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b882331 into develop Jan 12, 2024
65 checks passed
@khavinshankar khavinshankar deleted the fix-7018 branch January 12, 2024 14:44
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new nurse user type is marked as undefined in the doctor notes
3 participants