Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AssetFilter component to handle null facility value #7014

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jan 12, 2024

This pull request updates the AssetFilter component to handle a null facility value. Previously, the component assumed that the facility value would always be present, but this caused issues when the facility value was null. With this update, the component now correctly handles null facility values and ensures that the application functions as expected.

image

@Ashesh3 Ashesh3 requested a review from a team as a code owner January 12, 2024 10:37
Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 10:38am

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bd6cdf6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65a1166437d3a2000828922a
😎 Deploy Preview https://deploy-preview-7014--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jan 12, 2024

Passing run #1873 ↗︎

0 98 0 0 Flakiness 0

Details:

Update AssetFilter component to handle null facility value
Project: CARE Commit: bd6cdf6ad0
Status: Passed Duration: 02:19 💡
Started: Jan 12, 2024 10:41 AM Ended: Jan 12, 2024 10:43 AM

Review all test suite changes for PR #7014 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit f2bf161 into develop Jan 12, 2024
65 checks passed
@khavinshankar khavinshankar deleted the facility-filter-clear branch January 12, 2024 12:01
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants