Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes buggy prefetch condition for local body and district autocompletes #7006

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Jan 11, 2024
@rithviknishad rithviknishad requested a review from a team as a code owner January 11, 2024 08:55
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 11:59am

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d1aa48d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/659fd7e7353b08000825dc15
😎 Deploy Preview https://deploy-preview-7006--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jan 11, 2024

1 failed test on run #1862 ↗︎

1 97 0 0 Flakiness 0

Details:

Fixes buggy prefetch condition for local body and district autocompletes
Project: CARE Commit: d1aa48d435
Status: Failed Duration: 02:20 💡
Started: Jan 11, 2024 12:02 PM Ended: Jan 11, 2024 12:04 PM
Failed  cypress/e2e/patient_spec/patient_manage.cy.ts • 1 failed test

View Output

Test Artifacts
Patient > Discharge a patient Test Replay Screenshots

Review all test suite changes for PR #7006 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 901f619 into develop Jan 11, 2024
35 of 38 checks passed
@khavinshankar khavinshankar deleted the fix-7005 branch January 11, 2024 14:02
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 Not found errors on district and local bodies in Advanced Filters
3 participants