Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace useDispatch with useQuery in Asset Management, Location Management, Facility Cover Image Popup, Doctor Capacity and Triage #7004

Merged
merged 10 commits into from
Jan 31, 2024

Conversation

rithviknishad
Copy link
Member

Affects the following functionalities:

  • Facility Cover Image (Delete operation)
  • Location Form (Create/Edit operation)
  • Asset Form (Create/Edit operation)
  • Facility Doctor Capacity Form and Delete Specialization
  • Facility Triage Form

Other changes

  • Removed unused references in actions.tsx

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner January 11, 2024 04:37
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 4:35am

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f4e7806
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65af41e696f681000824e55f
😎 Deploy Preview https://deploy-preview-7004--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 8a65e3b
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/659f7071a524e100080688c9

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Jan 11, 2024
@rithviknishad rithviknishad added needs testing and removed Deploy-Failed Deplyment is not showing preview labels Jan 11, 2024
Copy link

cypress bot commented Jan 11, 2024

Passing run #1944 ↗︎

0 104 0 0 Flakiness 0

Details:

Replace `useDispatch` with `useQuery` in Asset Management, Location Management, ...
Project: CARE Commit: f4e780678a
Status: Passed Duration: 02:44 💡
Started: Jan 23, 2024 4:38 AM Ended: Jan 23, 2024 4:41 AM

Review all test suite changes for PR #7004 ↗︎

@rithviknishad rithviknishad added cypress failed pull request with cypress test failure and removed needs testing labels Jan 11, 2024
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 19, 2024
@rithviknishad rithviknishad removed stale cypress failed pull request with cypress test failure labels Jan 19, 2024
@rithviknishad rithviknishad added reviewed reviewed by a core member and removed needs review labels Jan 25, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 9f852af into develop Jan 31, 2024
61 of 62 checks passed
@khavinshankar khavinshankar deleted the useQuery-migrations/doctor-capacity branch January 31, 2024 07:42
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants