Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new routes to prescriptions. #6982

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Added new routes to prescriptions. #6982

merged 3 commits into from
Jan 17, 2024

Conversation

sriharsh05
Copy link
Contributor

@sriharsh05 sriharsh05 commented Jan 5, 2024 •
edited
Loading

Proposed Changes

Added new routes to prescriptions.

1.Inhalation
2.Nasogastric/Gastrostomy tube
3.intrathecal injection
4.Transdermal
5.Rectal

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sriharsh05 sriharsh05 requested a review from a team as a code owner January 5, 2024 11:23
@vercel Vercel
Copy link

vercel bot commented Jan 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 4:03pm

@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e480c4c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65a6a8ba7d4f220008a25d3f
😎 Deploy Preview https://deploy-preview-6982--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just a minor suggestion, there's a better way to manage types for these

src/Components/Medicine/CreatePrescriptionForm.tsx Outdated Show resolved Hide resolved
src/Components/Medicine/models.ts Outdated Show resolved Hide resolved
@rithviknishad
Copy link
Member

@sriharsh05 kindly link the backend PR too in the main comment once ready for testing

@sainak sainak mentioned this pull request Jan 5, 2024
Merged
4 tasks
@rithviknishad rithviknishad added reviewed reviewed by a core member and removed waiting for backend labels Jan 17, 2024
@khavinshankar khavinshankar merged commit eb64b28 into ohcnetwork:develop Jan 17, 2024
34 of 36 checks passed
@github-actions GitHub Actions
Copy link

@sriharsh05 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

Assignees
No one assigned
Labels
reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route of medicine- Add inhalation/ryles tube
5 participants
@sriharsh05 @rithviknishad @Ashesh3 @khavinshankar @nihal467