Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix daily rounds vital fields not clearing #6954

Merged
merged 4 commits into from
Dec 30, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • fix daily rounds vital fields not clearing

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner December 30, 2023 14:29
Copy link

vercel bot commented Dec 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 5:07pm

Copy link

netlify bot commented Dec 30, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ab0d571
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65904e39e2f97100071b19e0
😎 Deploy Preview https://deploy-preview-6954--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Dec 30, 2023
Copy link

cypress bot commented Dec 30, 2023

Passing run #1802 ↗︎

0 95 0 0 Flakiness 0

Details:

fix daily rounds vital fields not clearing
Project: CARE Commit: 0c96c90800
Status: Passed Duration: 02:26 💡
Started: Dec 30, 2023 4:38 PM Ended: Dec 30, 2023 4:41 PM

Review all test suite changes for PR #6954 ↗︎

@khavinshankar khavinshankar merged commit c5c86aa into develop Dec 30, 2023
34 of 38 checks passed
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the fix-dailyrounds-not-clearing branch December 30, 2023 17:11
Ashesh3 added a commit that referenced this pull request Jan 2, 2024
* fix daily rounds vital fields not clearing

* Fix blood pressure form field and daily rounds component

* Fix default blood pressure values in DailyRounds component

* Fix handling of negative values in blood pressure

---------

Co-authored-by: Ashesh3 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants