-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Asset Downtime on assets lists page #6952
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right way to do it. The asset list page now fetches paginated assets in one call, and paginated availability records in another call.
This does not ensure that you have the availability records of all the assets of the current assets in view.
I think the solution is to add a serializer-level field in the asset list API's serializer that says whether it is down or not.
cc: @Ashesh3
Also, some other icon would be better. A setting cog icon does not suit for indicating downtime. |
I agree with you here.
^ this is the ideal solution |
👋 Hi, @Pranshu1902, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@rithviknishad is this icon ok? |
@Pranshu1902 the backend review is still going on, posting the test to next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nihal467 @khavinshankar the backend PR has been merged, this PR is good to merge |
LGTM |
@Pranshu1902 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Proposed Changes
Show Asset Downtime on the assets lists page if last uptime status was "down"
Backend PR: #1794
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist