Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button in CNS is not Working #6899

Closed
konavivekramakrishna opened this issue Dec 23, 2023 · 1 comment · Fixed by #6908
Closed

Back button in CNS is not Working #6899

konavivekramakrishna opened this issue Dec 23, 2023 · 1 comment · Fixed by #6908
Labels
bug Something isn't working

Comments

@konavivekramakrishna
Copy link
Contributor

konavivekramakrishna commented Dec 23, 2023

Describe the bug
In CNS,
clicking on back button ideally it should redirect to the specific facility or facility tab but clicking on it the page simply refreshes without any changes
url : https://care.ohc.network/facility/ea9a2fbe-74f3-446b-bdb0-e038766bfb09/cns?page=1&limit=6

To Reproduce
Steps to reproduce the behavior:

  1. Go to Facility tab
  2. Click on view cns for any facility
  3. Click on back button
  4. See error

Expected behavior
it should redirect to the specific facility or facility tab

cc : @rithviknishad

@github-project-automation github-project-automation bot moved this to Triage in Care Dec 23, 2023
@konavivekramakrishna konavivekramakrishna changed the title Back button is not Working Back button in CNS is not Working Dec 23, 2023
@rithviknishad
Copy link
Member

rithviknishad commented Dec 24, 2023

Same issue is present for all tabs too (facility list, patient list, asset list), etc...

Looks like the pagination query parameters are being applied after being mounted causing it to have an additional navigation in the history.

Pressing back takes to the previous URL, but pagination filter gets reapplied, and hence stuck in a loop.

@rithviknishad rithviknishad moved this from Triage to Up Next in Care Dec 24, 2023
@rithviknishad rithviknishad added the bug Something isn't working label Dec 24, 2023
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants