Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all window.location.reload() with data refetch. #6892

Merged
merged 8 commits into from
Dec 28, 2023

Conversation

sriharsh05
Copy link
Contributor

@sriharsh05 sriharsh05 commented Dec 21, 2023

Proposed Changes

  • Fixes CARE reloads when a patient is discharged #6756
  • replaced window.location.reload with fetchdata function in patient discharge.
  • replaced window.location.reload with refetch while updating facility cover image.
  • replaced window.location.reload with refetch in assetImportModal.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sriharsh05 sriharsh05 requested a review from a team as a code owner December 21, 2023 14:02
Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 6:16pm

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 42dce58
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/658480e4978df7000848a5c8
😎 Deploy Preview https://deploy-preview-6892--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/Components/Common/UpdatableApp.tsx Outdated Show resolved Hide resolved
src/Components/Assets/AssetImportModal.tsx Outdated Show resolved Hide resolved
src/Components/Assets/AssetsList.tsx Outdated Show resolved Hide resolved
src/Components/Patient/PatientInfoCard.tsx Outdated Show resolved Hide resolved
src/Components/Patient/PatientInfoCard.tsx Outdated Show resolved Hide resolved
src/Components/Users/UserProfile.tsx Outdated Show resolved Hide resolved
@sriharsh05
Copy link
Contributor Author

@rithviknishad
Please review the changes.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 283504d into ohcnetwork:develop Dec 28, 2023
28 checks passed
Copy link

@sriharsh05 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Ashesh3 pushed a commit that referenced this pull request Jan 2, 2024
* replaced window.location.reload with appropriate fetchdata function in patient discharge

* replaced window.location.reload with appropriate refetch while updating facility cover image

* replaced window.location.reload with appropriate refetch in assetImportModal

* replaced wimdow.location.reload with appropriate refecth in update app

* Reverted changes made related to UpdatableApp

* removed unnecessary data fetch calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CARE reloads when a patient is discharged
4 participants