Use resolved_middleware for overrides #6875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ashesh3
commented
Dec 19, 2023
| @@ -192,7 +192,7 @@ const FilePreviewDialog = (props: FilePreviewProps) => { | |||
| /> | |||
| ) : ( | |||
| <iframe | |||
| sandbox | |||
| sandbox="" | |||
There was a problem hiding this comment.
(property) IframeHTMLAttributes<HTMLIFrameElement>.sandbox?: string | undefined
Passing run #1735 ↗︎
Details:
Review all test suite changes for PR #6875 ↗︎ |
|||||||||||||||
|
LGTM |
khavinshankar
approved these changes
Dec 28, 2023
|
@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Ashesh3
added a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
resolved_middlewarefor Middleware Management and Uptime Checks #6803This pull request refactors the usage of the middleware hostname in the CameraFeed components. It removes the fallbackMiddleware prop and replaces it with the resolved_middleware.hostname property from the asset object. This improves the code readability and simplifies the logic.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
copilot:walkthrough