Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip in users #6827

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Fix tooltip in users #6827

merged 3 commits into from
Dec 13, 2023

Conversation

AshrafMd-1
Copy link
Contributor

@AshrafMd-1 AshrafMd-1 commented Dec 8, 2023

WHAT

🤖[deprecated] Generated by Copilot at 33ecec7

Fixed a bug in SkillsSlideOver.tsx that showed a misleading tooltip message. The tooltip class is now applied only when the user does not have permission to add new skills.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 33ecec7

  • Conditionally apply tooltip class to div element based on authorizeForAddSkill value (link). This prevents showing an unnecessary tooltip message to users who have permission to add new skills in the SkillsSlideOver component, which displays and edits the skills of a user in the src/Components/Users/SkillsSlideOver.tsx file.

@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner December 8, 2023 15:08
Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 2:07pm

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0e6fcad
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/657868d0672eed000886139d
😎 Deploy Preview https://deploy-preview-6827--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad can u check once

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 20e706f into ohcnetwork:develop Dec 13, 2023
28 of 36 checks passed
@AshrafMd-1 AshrafMd-1 deleted the Fix-#6776 branch December 13, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear selection tooltip shown even when mouse is hovered on the add button instead of clear selection button
4 participants