Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cypress Test | Facility Triage Functionality | Facility Tab #6795

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Dec 4, 2023

WHAT

🤖[deprecated] Generated by Copilot at b0d8c26

The pull request adds and updates test cases for the facility triage and update functions using Cypress. It also adds id attributes to some elements in the facility triage component and new methods to the FacilityPage class in the page object model. These changes improve the test coverage and reliability of the facility features.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at b0d8c26

  • Add and modify test cases for facility triage and update functions (link, link, link, link)
  • Use new constants for input and output values (link, link)
  • Verify error message for missing triage entry date (link)
  • Check triage table and edit button after adding and editing triage details (link)
  • Check facility home page after updating facility address and oxygen capacity (link)
  • Add new methods for facility triage actions and assertions in page object model (link)
    • Use FacilityPage class in FacilityCreation.ts file (link)
  • Add id attributes to triage buttons and table elements in FacilityHomeTriage.tsx file (link, link, link)
    • Use ids to locate elements in test cases (link, link, link)

@nihal467 nihal467 requested a review from a team as a code owner December 4, 2023 20:45
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b0d8c26
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/656e3a7e3f0da5000832f07a
😎 Deploy Preview https://deploy-preview-6795--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Dec 4, 2023 8:45pm

Copy link

cypress bot commented Dec 4, 2023

Passing run #1681 ↗︎

0 91 0 0 Flakiness 0

Details:

New Cypress Test | Facility Triage Functionality | Facility Tab
Project: CARE Commit: b0d8c26470
Status: Passed Duration: 02:13 💡
Started: Dec 4, 2023 8:49 PM Ended: Dec 4, 2023 8:51 PM

Review all test suite changes for PR #6795 ↗︎

@khavinshankar khavinshankar merged commit b4edef2 into develop Dec 5, 2023
64 of 65 checks passed
@khavinshankar khavinshankar deleted the test-facility-triage branch December 5, 2023 06:14
Copy link

github-actions bot commented Dec 5, 2023

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants