-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a Date/time and round type filter for log updates #6713
Added a Date/time and round type filter for log updates #6713
Conversation
DailyRoundsFilter component
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
still date/time filter is not functional apart from that any changes required |
Also, clear the merge conflicts |
👋 Hi, @konavivekramakrishna, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Required Backends:cc: @nihal467 |
@konavivekramakrishna I've taken care of the |
@konavivekramakrishna VENTILATOR rounds are white-labelled as Critical Care in the log update form. We can white-label it here too. |
should I remove ICU and automated from filter? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use translations instead.
Also update the EN locale json file to have this.
LGTM |
DailyRoundsFilter component
WHAT
🤖[deprecated] Generated by Copilot at 9cb6f5d
This pull request refactors the code for filtering daily rounds in the consultation updates tab. It introduces a new component
DailyRoundsFilter
that renders a popover button for selecting the filter criteria. It also removes theshowAutomatedRounds
state variable and UI elements, and replaces them with afilter
state variable and query parameter that contains the round type, from date, and to date values. Thefilter
state variable is defined by a new interfaceDailyRoundsFilterModel
in thesrc/Components/Facility/models.tsx
file.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖[deprecated] Generated by Copilot at 9cb6f5d
DailyRoundsFilter
to filter the daily rounds list by round type, from date, and to date (link)DailyRoundsList
component to use theDailyRoundsFilter
component and thefilter
state variable instead of theshowAutomatedRounds
prop and query parameter (link)showAutomatedRounds
state variable, UI elements, and prop from theConsultationUpdatesTab
andDailyRoundsList
components (link, link, link)DailyRoundsFilterModel
to define the shape of thefilter
state variable (link)