Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cypress for doctor notes #6703

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Fix cypress for doctor notes #6703

merged 1 commit into from
Nov 24, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Nov 23, 2023

WHAT

🤖[deprecated] Generated by Copilot at 4925c8f

This pull request improves the cypress test for the patient consultation page and adds id attributes to the PatientNotesSlideover component. The test is updated to reflect the new UI for the doctor notes section and the id attributes are added to make the elements easier to locate by cypress.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖[deprecated] Generated by Copilot at 4925c8f

  • Add id attributes to the elements in the patient notes slideover component to facilitate cypress testing (link, link, link) in src/Components/Facility/PatientNotesSlideover.tsx

@Ashesh3 Ashesh3 requested a review from a team November 23, 2023 17:40
@Ashesh3 Ashesh3 requested a review from a team as a code owner November 23, 2023 17:40
@Ashesh3 Ashesh3 requested a review from vigneshhari November 23, 2023 17:40
Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4925c8f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/655f8e9c0c0d1a0008525fff
😎 Deploy Preview https://deploy-preview-6703--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Nov 23, 2023 5:40pm

Copy link

cypress bot commented Nov 23, 2023

Passing run #1605 ↗︎

0 85 0 0 Flakiness 0

Details:

Fix cypress for doctor notes
Project: CARE Commit: 4925c8f1cc
Status: Passed Duration: 07:27 💡
Started: Nov 23, 2023 6:04 PM Ended: Nov 23, 2023 6:11 PM

Review all test suite changes for PR #6703 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b9c7021 into develop Nov 24, 2023
37 checks passed
@khavinshankar khavinshankar deleted the fix-doc-notes-cypress branch November 24, 2023 06:11
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress Failure : Doctor Notes
3 participants