Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide KASP Advance Filter #6687

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

konavivekramakrishna
Copy link
Contributor

@konavivekramakrishna konavivekramakrishna commented Nov 21, 2023

WHAT

🤖[deprecated] Generated by Copilot at e06ac31

Improved facility filter component by removing unused code and adding an accordion for kasp_empanelled field.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at e06ac31

  • Wrap kasp_empanelled filter field in an AccordionV2 component to improve UI (link, link, link)
  • Remove unused useConfig hook and kasp_string variable from FacilityFilter component (link, link)

@konavivekramakrishna konavivekramakrishna requested a review from a team November 21, 2023 18:16
@konavivekramakrishna konavivekramakrishna requested a review from a team as a code owner November 21, 2023 18:16
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 4:03pm

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c48f24f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6560c905eb74e900085eae1d
😎 Deploy Preview https://deploy-preview-6687--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the issue about removing the filter altogether from the UI since it has no value?

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are also to be removed right?

image

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 8f76361 into ohcnetwork:develop Nov 29, 2023
36 checks passed
@konavivekramakrishna konavivekramakrishna deleted the fix#6607 branch December 1, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide KASP Advance Filter in the facility advance filter
4 participants