Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the delete facility button to be hidden and not diabled #6677

Closed
wants to merge 13 commits into from

Conversation

xakep8
Copy link
Contributor

@xakep8 xakep8 commented Nov 21, 2023

WHAT

🤖[deprecated] Generated by Copilot at 5593dc2

Restrict Delete Facility option to authorized users. Modify src/Components/Facility/FacilityHome.tsx to check user type before rendering the option.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 5593dc2

  • Restrict the Delete Facility option to users with DistrictAdmin or StateAdmin roles (link)

@xakep8 xakep8 requested a review from a team November 21, 2023 06:17
@xakep8 xakep8 requested a review from a team as a code owner November 21, 2023 06:17
@xakep8 xakep8 requested a review from mathew-alex November 21, 2023 06:17
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 0:08am

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 29c918a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/656f12b1a5ebde0008990e9b
😎 Deploy Preview https://deploy-preview-6677--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 29, 2023
Copy link

👋 Hi, @xakep8,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Nov 29, 2023
@nihal467
Copy link
Member

nihal467 commented Dec 5, 2023

image

bug: Even as a Palakkad district admin I am not able to delete a facility

the following things need to be addressed in the PR :

  1. Modify the user access as state admin and above can only delete a facility
  2. Only empty facilities with no patient data should be allowed to be deleted.

@xakep8
Copy link
Contributor Author

xakep8 commented Dec 5, 2023

@nihal467 How may I join the EOD call?

@nihal467
Copy link
Member

nihal467 commented Dec 5, 2023

@xakep8 make the below changes

  • Modify the user access as state admin and above can only delete a facility
  • Only facilities with no patient data should be allowed to be deleted.
  • In case a user attempts to delete a facility with any type of patient data in it, it shouldn't allow the user to delete it and should throw an error.

@xakep8 The EOD call links are shared in the Reminders channel of the OHC Community Slack workspace. (" https://join.slack.com/t/rebuildearth/shared_invite/zt-28b6p14th-OLAHD9oR9oFLYeSCitrXYw ")

Discussion on EOD call 05/12/2023

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 13, 2023
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Dec 21, 2023
@xakep8 xakep8 deleted the facility_delete branch September 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the Delete Facility for user who don't have access to do it
3 participants