Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showing errors on wrong numbers in PhoneNumberFormField #6675

Merged
merged 6 commits into from
Nov 30, 2023
Merged

showing errors on wrong numbers in PhoneNumberFormField #6675

merged 6 commits into from
Nov 30, 2023

Conversation

kshitijv256
Copy link
Contributor

@kshitijv256 kshitijv256 commented Nov 20, 2023 •
edited by ghost
Loading

WHAT

🤖[deprecated] Generated by Copilot at 02ff7fb

Removed unused errorClassName props from some components and simplified error handling logic in user filter and shifting list filter forms. These changes improve the code readability and maintainability.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Screenshot

Screenshot from 2023-11-20 23-31-52

@kshitijv256 kshitijv256 requested a review from a team November 20, 2023 18:09
@kshitijv256 kshitijv256 requested a review from a team as a code owner November 20, 2023 18:09
@vercel Vercel
Copy link

vercel bot commented Nov 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2023 6:56pm

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 21d33ab
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6562433e9474a60008aa5be2
😎 Deploy Preview https://deploy-preview-6675--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace between the input fields are not consistent now

@kshitijv256
Copy link
Contributor Author

@rithviknishad @nihal467
Fixed the incorrect spacing problem

Screenshot from 2023-11-25 22-41-34

rithviknishad
rithviknishad requested changes Nov 25, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right way is to adjust the parent div's gap-[x] tailwindcss class of the filters

src/Components/Form/FormFields/FormField.tsx Outdated Show resolved Hide resolved
rithviknishad
rithviknishad requested changes Nov 25, 2023
View reviewed changes
src/Components/Users/UserFilter.tsx Outdated Show resolved Hide resolved
src/Components/Users/UserFilter.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit fe28c4e into ohcnetwork:develop Nov 30, 2023
36 checks passed
@kshitijv256 kshitijv256 deleted the phone_error branch December 4, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phone validation errors are not being shown during onBlur
4 participants
@kshitijv256 @nihal467 @rithviknishad @khavinshankar