Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dosage field in prescription are malfunctioning #6625

Closed
nihal467 opened this issue Nov 15, 2023 · 7 comments · Fixed by #6626
Closed

Dosage field in prescription are malfunctioning #6625

nihal467 opened this issue Nov 15, 2023 · 7 comments · Fixed by #6626
Assignees
@AshrafMd-1
Labels
bug Something isn't working P1 breaking issue or vital feature urgent

Comments

@nihal467
Copy link
Member

Describe the bug

when we input a lot of zero initially and input any integer, the dosage accepts the value and causes the UI to break.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'prescription of any patient
  2. Add dosage with lots of zeros initially and submit it
  3. See error

Expected behavior

It should accept only valid inputs

Screenshots

image
@github-project-automation github-project-automation bot moved this to Triage in Care Nov 15, 2023
@nihal467 nihal467 added bug Something isn't working urgent P1 breaking issue or vital feature labels Nov 15, 2023
@github-actions GitHub Actions
Copy link

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.

@AshrafMd-1
Copy link
Contributor

AshrafMd-1 commented Nov 15, 2023 •
edited
Loading

I want to work on this issue can u assign me this?

@nihal467
Copy link
Member Author

nihal467 commented Nov 15, 2023 •
edited
Loading

@AshrafMd-1 can you push the fix by EOD, its a P1 Urgent issue

@nihal467 nihal467 changed the title Dosage field in prescription are malficntioning Dosage field in prescription are malfunctioning Nov 15, 2023
@AshrafMd-1
Copy link
Contributor

@AshrafMd-1 can you push the fix by EOD, its a P1 Urgent issue

okay I will

@AshrafMd-1 AshrafMd-1 mentioned this issue Nov 15, 2023
Merged
6 tasks
@AshrafMd-1
Copy link
Contributor

AshrafMd-1 commented Nov 15, 2023 •
edited
Loading

@nihal467 i have submitted a PR.

@rithviknishad
Copy link
Member

@AshrafMd-1 also create a backend issue for this, to sanitize/validate the dosage fields

@rithviknishad rithviknishad moved this from Triage to In Progress in Care Nov 15, 2023
@AshrafMd-1
Copy link
Contributor

@rithviknishad created an issue

@github-project-automation github-project-automation bot moved this from In Progress to Done in Care Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AshrafMd-1 AshrafMd-1

Labels
bug Something isn't working P1 breaking issue or vital feature urgent
Projects
Care
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed dosage field malfunctioning. AshrafMd-1/care_fe
3 participants
@rithviknishad @nihal467 @AshrafMd-1