Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve Applied Advance filter in facility page while switching #6605

Closed
1 task
nihal467 opened this issue Nov 15, 2023 · 7 comments · Fixed by #6695
Closed
1 task

Preserve Applied Advance filter in facility page while switching #6605

nihal467 opened this issue Nov 15, 2023 · 7 comments · Fixed by #6695

Comments

@nihal467
Copy link
Member

nihal467 commented Nov 15, 2023

Describe the bug

  • currently when we switch tabs, the Applied Advance filter in facility page are not preserved

Expected behavior

Preserve Applied Advance filter in facility page while switching in between tab

Screenshots

image

@konavivekramakrishna
Copy link
Contributor

I would like to work on it, can you please assign me

@rithviknishad
Copy link
Member

@konavivekramakrishna this would be a backend issue

@konavivekramakrishna
Copy link
Contributor

konavivekramakrishna commented Nov 20, 2023

@nihal467

Can you please provide me with the login details of a district admin or user from a state other than Kerala

@konavivekramakrishna
Copy link
Contributor

@rithviknishad

If I'm not mistaken, the state and district for which a user has access are stored in the state_object, and the district_object isn't, right?

Also, I have a doubt: Can a user have access to multiple states and districts? If not, we can remove these from the filtering.

image

@rithviknishad
Copy link
Member

If I'm not mistaken, the state and district for which a user has access are stored in the state_object, and the district_object isn't, right?

Correct.

Also, I have a doubt: Can a user have access to multiple states and districts? If not, we can remove these from the filtering.

The highest user type we have is a State Admin, which will be linked to a particular state always. Hence the state filter seems to be a no-op. We could remove it from the filters right @nihal467? Am I missing any other cases?

State Admins will be able to access multiple districts. Users less than or equal to the District Admin can have a disabled district filter with the accessible district pre-filled.

@konavivekramakrishna
Copy link
Contributor

konavivekramakrishna commented Nov 22, 2023

@nihal467

can you please provide the login details for state admin

@nihal467 nihal467 changed the title Facility Advance Filter dropdown is showing all state list irrespective of user access Preserve Applied Advance filter in facility page while switching Nov 22, 2023
@konavivekramakrishna konavivekramakrishna removed their assignment Nov 23, 2023
@konavivekramakrishna
Copy link
Contributor

fixed in 6695

@rithviknishad rithviknishad linked a pull request Nov 24, 2023 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants