Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary multiple cancel buttons and added a Back button. #6579

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Removed unnecessary multiple cancel buttons and added a Back button. #6579

merged 6 commits into from
Nov 22, 2023

Conversation

KshitijTodkar48
Copy link
Contributor

@KshitijTodkar48 KshitijTodkar48 commented Nov 9, 2023 •
edited
Loading

Proposed Changes

Removing multiple unnecessary cancel buttons on the configure facility page.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • [ x] Ensure that UI text is kept in I18n files.
  • [ x] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ x] Request for Peer Reviews
  • Completion of QA

Screenshot 2023-11-10 145302

@KshitijTodkar48 KshitijTodkar48 requested a review from a team November 9, 2023 19:57
@KshitijTodkar48 KshitijTodkar48 requested a review from a team as a code owner November 9, 2023 19:57
@netlify Netlify
Copy link

netlify bot commented Nov 9, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e8fa5ac
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/655cb8eef67d0900086911a3
😎 Deploy Preview https://deploy-preview-6579--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel Vercel
Copy link

vercel bot commented Nov 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 2:05pm

rithviknishad
rithviknishad requested changes Nov 10, 2023
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
src/Components/Facility/FacilityConfigure.tsx Outdated Show resolved Hide resolved
src/Components/Common/components/ButtonV2.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

@KshitijTodkar48 Two separate cards with no cancel button seem giving a good look to the UI, marking this PR for discussion

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b8d8070 into ohcnetwork:develop Nov 22, 2023
33 of 36 checks passed
@KshitijTodkar48 KshitijTodkar48 deleted the fix/Unnecessary-multiple-cancel-buttons branch November 22, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure Facility: Unnecessary multiple cancel buttons present
4 participants
@KshitijTodkar48 @nihal467 @rithviknishad @khavinshankar