Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned buttons to right #6573

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

konavivekramakrishna
Copy link
Contributor

@konavivekramakrishna konavivekramakrishna commented Nov 9, 2023

WHAT

🤖 Generated by Copilot at c427646

Simplify the layout and reduce the padding of the facility card component. Remove an extra div element from src/Components/Facility/FacilityCard.tsx. The change is part of a UI improvement pull request.

Proposed Changes

image

After

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at c427646

  • Remove unnecessary div element and reduce vertical padding in facility card layout (link)

@konavivekramakrishna konavivekramakrishna requested a review from a team November 9, 2023 10:25
@konavivekramakrishna konavivekramakrishna requested a review from a team as a code owner November 9, 2023 10:25
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 3:59pm

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 40c3682
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65563c2e760aa90008ef77b6
😎 Deploy Preview https://deploy-preview-6573--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 10, 2023
Copy link

👋 Hi, @konavivekramakrishna,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 2f1d4e7
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/654f3e12eb3fb100083a9eca

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Nov 11, 2023
@rithviknishad rithviknishad removed Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict labels Nov 11, 2023
@konavivekramakrishna konavivekramakrishna changed the title aligned buttons to right Aligned buttons to right Nov 13, 2023
@nihal467
Copy link
Member

image

the grey padding for the button are reduced compared to the existing staging, was it intentional

@rithviknishad @konavivekramakrishna

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 11da461 into ohcnetwork:develop Nov 21, 2023
34 of 36 checks passed
@konavivekramakrishna konavivekramakrishna deleted the fix#6560 branch November 22, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "view facility" , "View Patient" and "Notice" buttons right aligned in facility card
4 participants