-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(location): duty doctors and staff for each location in a facility #6512
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@cp-coder the maximum 3 users limitation per location was discussed in EOD, as I am unable to find it mentioned in the issue |
Actually, Aakash wanted a validation for limiting the number of staffs assigned to any particular location that's why I added a limit of 3 doctors and 3 staffs per location. I had a talk with him in the EOD. |
@cp-coder don't keep the limitation, remove the maximum limitation |
@nihal467 I have removed the max limit |
👋 Hi, @cp-coder, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
👋 Hi, @cp-coder, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@cp-coder there is a merge conflict and backend require changes |
👋 Hi, @aeswibon, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Marking as hold as the requirements have changed and a more refined feature "User Availability" will be built that adds more depth and it would replace the "Duty Staff for Locations" feature. Issue: #6968 |
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
@rithviknishad can you clear the merge conflict , as there are bigger file changes |
Closing this PR due to lack of recent progress. |
Bug Fix
WHAT
🤖 Generated by Copilot at 15b419f
This pull request adds the feature of assigning and updating duty staff for a location in the asset management module. It also adds localization support for the location management components using the
react-i18next
module. It modifies the type definitions, models, actions, and api modules to support this feature and improves the code quality and organization. It also adds theLocation.json
file to thesrc/Locale/en
folder for the English translation of the location-related text.Proposed Changes
Duty Staff
section to location formdoctors
andstaff
with each locationAssociated Issue
Screenshot
Normal: Modal for Assigning Duty Staff
Success: Assigning duty staff
Success: Removing duty staff
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 15b419f
Location.json
file to thesrc/Locale/en
folder with the key-value pairs for the text in the location management components (link)index.js
file in thesrc/Locale/en
folder to import and export theLocation.json
file (link, link)useTranslation
hook and thet
function to enable the localization of the text in theLocationManagement
andLocationCard
components (link, link, link, link, link)UserAssignedModel
interface to theAssetTypes.tsx
module and import it in themodels.tsx
andAssetTypes.tsx
modules (link, link, link)duty_staff_objects
field to theLocationModel
interface in themodels.tsx
module and pass it as a prop to theLocationCard
component (link, link)createFacilityAssetLocationDutyStaff
function to theactions.tsx
module and thecreateFacilityAssetLocationDutyStaff
property to theroutes
object in theapi.tsx
module (link, link)AddLocationForm
component in theAddLocationForm.tsx
module to include the state variables, logic, and UI elements for adding and updating the duty staff for a location (link, link, link, link, link, link, link, link)FacilityModel
,LocationModel
, andWardModel
interfaces from theapi.tsx
module and move them to a more appropriate place (link, link)