Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily Rounds: Updated consciousness levels choices to MEWS #6435

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Oct 11, 2023

Bug Fix

WHAT

🤖 Generated by Copilot at b0f180b

This pull request refactors and enhances the CriticalCare__NeurologicalMonitoring component and its related type. It simplifies the state management, improves the UI layout, and uses more precise and consistent values for the consciousnessLevel field.

Required Backends

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at b0f180b

  • Update the type definition, encoding, decoding, and string conversion of the consciousnessLevel variant to reflect the new options for the neurological monitoring input (link, link, link, link)
  • Simplify the state update logic for the SetConsciousnessLevel, SetLeftPupilSizeDetails, SetLeftPupilLightReaction, SetLeftPupilLightReactionDetails, SetRightPupilSizeDetails, SetRightPupilLightReaction, SetRightPupilLightReactionDetails, SetLimbResponseUpperExtremityRight, SetLimbResponseUpperExtremityLeft, SetLimbResponseLowerExtremityRight, and SetLimbResponseLowerExtremityLeft actions by removing redundant assignments of the same variable name to the same value (link, link, link, link)
  • Modify the layout of the radio buttons for the consciousnessLevel input in the CriticalCare__NeurologicalMonitoringEditor.res file by using a grid instead of a flexbox, to make it more responsive and consistent across different screen sizes and devices (link)
  • Remove the conditional rendering of the CriticalCare__Description component for the consciousnessLevel reaction description in the CriticalCare__NeurologicalMonitoringEditor.res file, as it is no longer needed due to the more descriptive and specific options for the consciousnessLevel input (link)

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 9:25am

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 558d369
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/652fa464471997000904174f
😎 Deploy Preview https://deploy-preview-6435--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aeswibon aeswibon marked this pull request as ready for review October 11, 2023 11:57
@aeswibon aeswibon requested a review from a team October 11, 2023 11:57
@aeswibon aeswibon requested a review from a team as a code owner October 11, 2023 11:57
@aeswibon aeswibon requested a review from mathew-alex October 11, 2023 11:57
@aeswibon aeswibon added P1 breaking issue or vital feature urgent waiting for backend labels Oct 11, 2023
@nihal467
Copy link
Member

@cp-coder
image

in the neurological monitor reflection tab, the existing data as well the new data, is not showing the new labelling

@rithviknishad
Copy link
Member

@nihal467 i've fixed the above mentioned issues, could you check again?

@rithviknishad rithviknishad changed the title fixed: aligning consciousness scale to MEWS Daily Rounds: Updated consciousness levels choices to MEWS Oct 18, 2023
@nihal467
Copy link
Member

nihal467 commented Oct 18, 2023

@rithviknishad

current staging

image

existing PR

image

on the unresponsive and alert data reflection the UI breaks, all other functionality looks good to me

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 6ee8422 into ohcnetwork:develop Oct 18, 2023
28 checks passed
Ashesh3 pushed a commit that referenced this pull request Oct 20, 2023
* fix(daily_round): aligned consciousness scale to mews

* fix(daily_round): removed optional description

* fix NeurologicalTables

* fix line break

---------

Co-authored-by: rithviknishad <[email protected]>
Ashesh3 pushed a commit that referenced this pull request Oct 23, 2023
* fix(daily_round): aligned consciousness scale to mews

* fix(daily_round): removed optional description

* fix NeurologicalTables

* fix line break

---------

Co-authored-by: rithviknishad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aligning Consciousness scale to MEWS
4 participants