Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cypress test to verify warranty expiry label on an asset #6428

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Oct 10, 2023

WHAT

🤖 Generated by Copilot at c6b8259

Added a new test case and helper methods to verify the asset service history alert feature based on the warranty expiry date. Modified the Chip and AssetsList components to add ids for testing. Added type annotations to some methods in the AssetPage class.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at c6b8259

  • Add a new test case to verify the asset service history alert feature (link)
  • Use a helper function to generate different warranty expiry dates (link)
  • Use a page object class to enter the warranty expiry dates and scroll to the warranty details section (link)
  • Use a component file to assign unique ids to the chip components that display the alert labels (link, link, link, link, link)
  • Use a helper function to verify the alert labels based on the warranty expiry dates (link)

@GokulramGHV GokulramGHV requested a review from a team October 10, 2023 10:46
@GokulramGHV GokulramGHV requested a review from a team as a code owner October 10, 2023 10:46
@GokulramGHV GokulramGHV requested a review from bodhish October 10, 2023 10:46
@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 9:27pm

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3cef624
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/652daa7b09c7d000081dc829
😎 Deploy Preview https://deploy-preview-6428--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GokulramGHV
Copy link
Member Author

@nihal467 I've updated the spec such that it also checks if the warranty expiry label goes off once the asset warranty is updated and set to greater than 3 months.

@GokulramGHV
Copy link
Member Author

Unfortunately, we wouldn't be able to check the expiry label since we can't set the warranty expiry to a past date.

@khavinshankar khavinshankar merged commit 7e29f25 into ohcnetwork:develop Oct 17, 2023
28 checks passed
rithviknishad pushed a commit that referenced this pull request Oct 17, 2023
* added cypress test to verify warranty expiry label

* updated spec to check if the warranty expiry label goes off once updated

* verify the last change

---------

Co-authored-by: Mohammed Nihal <[email protected]>
Ashesh3 pushed a commit that referenced this pull request Oct 20, 2023
* added cypress test to verify warranty expiry label

* updated spec to check if the warranty expiry label goes off once updated

* verify the last change

---------

Co-authored-by: Mohammed Nihal <[email protected]>
Ashesh3 pushed a commit that referenced this pull request Oct 23, 2023
* added cypress test to verify warranty expiry label

* updated spec to check if the warranty expiry label goes off once updated

* verify the last change

---------

Co-authored-by: Mohammed Nihal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cypress Test to verify Asset service history alert
3 participants