Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced date-fns utility functions from DateInputV2 component with day.js #6405

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Conversation

thedevildude
Copy link
Contributor

@thedevildude thedevildude commented Oct 5, 2023

WHAT

🤖 Generated by Copilot at a9a3a54

Refactored date input component to use dayjs library instead of date-fns. This improves consistency and compatibility with other components that use dayjs. Modified DateInputV2.tsx and related files to use dayjs methods for date operations and display.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at a9a3a54

  • Replace date-fns library with dayjs library for date manipulation and formatting in DateInputV2.tsx component (link)
  • Update switch cases for handling left and right arrow clicks on the date picker to use dayjs methods for subtracting and adding months, years, and decades (link, link)
  • Update functions for checking selected date and getting day count and blank days array to use dayjs methods for comparing and getting dates (link, link)
  • Update div and p elements for displaying month and year on the date picker header and grid to use dayjs methods for formatting dates (link, link, link)

@thedevildude thedevildude requested a review from a team October 5, 2023 16:27
@thedevildude thedevildude requested a review from a team as a code owner October 5, 2023 16:27
@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 9:51am

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ee75531
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6523cd0c62733c0008cc8e2f
😎 Deploy Preview https://deploy-preview-6405--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thedevildude thedevildude changed the title Issue#6305 Replaced date-fns utility functions from DateInputV2 component with day.js Oct 5, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

👋 Hi, @thedevildude,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467 nihal467 removed the merge conflict pull requests with merge conflict label Oct 8, 2023
@nihal467
Copy link
Member

nihal467 commented Oct 9, 2023

LGTM @rithviknishad @khavinshankar review it

@khavinshankar khavinshankar merged commit 0866331 into ohcnetwork:develop Oct 9, 2023
28 checks passed
@thedevildude thedevildude deleted the issue#6305 branch November 30, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove date-fns to reduce bundle size
3 participants