Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix password reset #6404

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Fix password reset #6404

merged 3 commits into from
Oct 6, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 5, 2023

WHAT

🤖 Generated by Copilot at 75dceaa

Allowed unauthenticated access to some authentication-related routes in api.tsx. This enables users to log in, reset their passwords, or request a password reset link without being logged in.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 75dceaa

  • Add noAuth property to routes that do not require authentication (link, link, link) in src/Redux/api.tsx

@Ashesh3 Ashesh3 requested a review from a team October 5, 2023 13:49
@Ashesh3 Ashesh3 requested a review from a team as a code owner October 5, 2023 13:49
@Ashesh3 Ashesh3 requested a review from mathew-alex October 5, 2023 13:49
@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3760ae2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/651f9cb84f464c0008f46b19
😎 Deploy Preview https://deploy-preview-6404--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 5:36am

@cypress
Copy link

cypress bot commented Oct 5, 2023

1 failed test on run #1372 ↗︎

1 77 0 0 Flakiness 0

Details:

Fix password reset
Project: CARE Commit: 3760ae2bc4
Status: Failed Duration: 03:15 💡
Started: Oct 6, 2023 5:40 AM Ended: Oct 6, 2023 5:43 AM
Failed  cypress/e2e/patient_spec/patient_crud.cy.ts • 1 failed test

View Output Video

Test Artifacts
Patient Creation with consultation > Create a New consultation to existing patient Test Replay Output Screenshots

Review all test suite changes for PR #6404 ↗︎

@nihal467 nihal467 added the P1 breaking issue or vital feature label Oct 5, 2023
@nihal467
Copy link
Member

nihal467 commented Oct 5, 2023

@Ashesh3
image

the bug still persist

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 6, 2023

@Ashesh3 image

the bug still persist

Fixed!

@nihal467
Copy link
Member

nihal467 commented Oct 6, 2023

LGTM

@khavinshankar khavinshankar merged commit 91abee0 into develop Oct 6, 2023
28 of 29 checks passed
@khavinshankar khavinshankar deleted the fix-6403 branch October 6, 2023 10:50
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password reset functionality is malfunctioning
4 participants