Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cypress test for asset transaction and service history's #6349

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Sep 26, 2023

WHAT

🤖 Generated by Copilot at 7f55921

The pull request enhances the asset management feature and its automated testing. It adds new test cases and methods for various aspects of creating, viewing, and editing assets and their service and transaction history. It also adds id attributes to several components and elements to improve the testability of the code. The changes affect the files cypress/e2e/assets_spec/assets_manage.cy.ts, cypress/pageobject/Facility/FacilityCreation.ts, cypress/pageobject/Asset/AssetCreation.ts, src/Components/Assets/AssetManage.tsx, src/Components/Assets/AssetServiceEditModal.tsx, src/Components/Facility/FacilityHome.tsx, and src/Components/Form/FormFields/Autocomplete.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 7f55921

  • Add id attributes to various elements in the AssetManage, AssetServiceEditModal, FacilityHome, and Autocomplete components for the asset management tests (link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Add new methods to the AssetPage class in cypress/pageobject/Asset/AssetCreation.ts for the asset management tests, such as clicking the update button, scrolling into notes and service history, entering asset notes and service date, viewing and editing the service history, verifying the asset location and transaction status, and clicking the asset location (link)
  • Add new methods to the FacilityPage class in cypress/pageobject/Facility/FacilityCreation.ts for the asset management tests, such as clicking the create asset and view asset options from the facility dropdown menu, verifying the facility badge content, the facility create asset and view asset redirection, and the asset facility back redirection (link, link)
  • Add three new test cases in cypress/e2e/assets_spec/assets_manage.cy.ts for the asset management feature, covering the scenarios of creating and editing a service history, creating an asset transaction, and verifying the facility asset page redirection (link, link)

@nihal467 nihal467 requested a review from a team September 26, 2023 09:20
@nihal467 nihal467 requested a review from a team as a code owner September 26, 2023 09:20
@nihal467 nihal467 requested a review from gigincg September 26, 2023 09:20
@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 9:25am

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d63f56a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6512a351b972d400090150d2
😎 Deploy Preview https://deploy-preview-6349--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 26, 2023

Passing run #1308 ↗︎

0 78 0 0 Flakiness 0

Details:

Create cypress test for asset transaction and service history's
Project: CARE Commit: d63f56a17f
Status: Passed Duration: 02:51 💡
Started: Sep 26, 2023 9:28 AM Ended: Sep 26, 2023 9:31 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@khavinshankar khavinshankar merged commit 0a7bee3 into develop Sep 26, 2023
28 of 29 checks passed
@khavinshankar khavinshankar deleted the Verify-asset-page-redirection branch September 26, 2023 09:47
@github-actions
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants