Assets date picker #6338
Merged
Assets date picker #6338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
requested changes
Sep 25, 2023
|
LGTM |
|
👋 Hi, @suprabathk, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
@rithviknishad can u re-review this once |
rithviknishad
requested changes
Sep 26, 2023
|
Refer: #4467 @suprabathk |
|
LGTM |
khavinshankar
approved these changes
Oct 4, 2023
|
@rithviknishad can you re-review this once |
rithviknishad
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 888cbe6
Replaced
DateInputV2withDateFormFieldin asset-related forms to improve date input and validation. Simplified theDateInputV2component by removing unused code. Added labels and comments for clarity.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 888cbe6
DateInputV2component withDateFormFieldcomponent inAssetServiceEditModal.tsxandAssetCreate.tsxto simplify label and error handling (link, link, link, link, link, link, link)useRefhook,popoverref,refprop, andonBlurhandler fromDateInputV2component inDateInputV2.tsxto clean up code (link, link, link, link)AssetCreate.tsxas a temporary workaround until translation files are updated (link)