Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vitals Monitor does not start if ECG wave-name is other than "II" #6198

Closed
rithviknishad opened this issue Sep 1, 2023 · 2 comments · Fixed by #6274
Closed

Vitals Monitor does not start if ECG wave-name is other than "II" #6198

rithviknishad opened this issue Sep 1, 2023 · 2 comments · Fixed by #6274
Assignees
@rithviknishad
Labels
P1 breaking issue or vital feature

Comments

@rithviknishad
Copy link
Member

Describe the bug
Vitals Monitor does not start if the ECG wave name is other than "II"

To Reproduce
Steps to reproduce the behavior:

  1. View a vitals monitor where ecg-waveform's wave-name is "II"

Expected behavior
ECG Waveform Channel can have multiple wave-names and should work with any of those.
A clear understanding is not there of what all wave-names are there at present. (Discussion)

cc: @gigincg @mathew-alex
@github-project-automation github-project-automation bot moved this to Triage in Care Sep 1, 2023
@rithviknishad
Copy link
Member Author

Solution we'll be doing is, we'll do an includes search for all roman leters from 1 to 4

@rithviknishad rithviknishad self-assigned this Sep 11, 2023
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Sep 11, 2023
rithviknishad added a commit that referenced this issue Sep 12, 2023
@rithviknishad
fixes #6198; add support to detect multiple ecg wavenames
7927849
@rithviknishad rithviknishad mentioned this issue Sep 12, 2023
Merged
6 tasks
@rithviknishad rithviknishad added the P1 breaking issue or vital feature label Sep 13, 2023
@github-actions
Copy link

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.
@rithviknishad kindly acknowledge this message by commenting 'Acknowledged' below.

khavinshankar pushed a commit that referenced this issue Sep 13, 2023
@rithviknishad
Vitals Monitor (HL7): Add support to detect multiple ecg wavenames (#…
cc6b570 
…6274)

* fixes #6198; add support to detect multiple ecg wavenames

* Update HL7DeviceClient.ts

* fix heart rate pulse rate fallback
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rithviknishad rithviknishad

Labels
P1 breaking issue or vital feature
Projects
Care
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vitals Monitor (HL7): Add support to detect multiple ecg wavenames ohcnetwork/care_fe
1 participant
@rithviknishad