Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock asset feature #5967

Closed
wants to merge 117 commits into from
Closed

Conversation

JahnabDutta
Copy link
Contributor

@JahnabDutta JahnabDutta commented Jul 29, 2023

WHAT

🤖 Generated by Copilot at d10864f

This pull request adds and improves features related to the ONVIF camera asset type, such as boundary preset management, camera locking and unlocking, and live feed display. It also fixes some bugs and simplifies some components. The main files affected are ONVIFCamera.tsx, useFeedPTZ.ts, Feed.tsx, CameraBoundaryConfigure.tsx, and fireRequest.tsx.

Proposed Changes

create locking meachism in the frontend and then control asset operations based on it.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at d10864f

  • Add and expose lockAsset and unlockAsset functions to useFeedPTZ hook (link, link, link, link)
  • Import and use LiveFeed component in ONVIFCamera component (link, link, link, link, link, link, link, link)
  • Define and use BoundaryRange interface and boundaryPreset state variable to store and manipulate the boundary preset data for the camera (link, link, link, link, link, link, link, link)
  • Define and use CameraBoundaryConfigure and UpdateCameraBoundaryConfigure components to render and handle the UI for the boundary preset (link)
  • Modify the other function in the cameraPTZ object to check and prevent the camera from moving beyond the boundary range or zooming out too much, and to send the boundary preset id and the camera state to the backend (link, link)
  • Add a condition to show an error notification when the user tries to access a locked asset (link)

JahnabDutta and others added 30 commits May 26, 2023 13:07
Signed-off-by: JahnabDutta <[email protected]>
Signed-off-by: JahnabDutta <[email protected]>
Signed-off-by: JahnabDutta <[email protected]>
Signed-off-by: JahnabDutta <[email protected]>
@JahnabDutta JahnabDutta marked this pull request as ready for review August 29, 2023 16:18
@github-actions github-actions bot added merge conflict pull requests with merge conflict and removed merge conflict pull requests with merge conflict labels Aug 30, 2023
@github-actions
Copy link

👋 Hi, @JahnabDutta,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Signed-off-by: JahnabDutta <[email protected]>
Signed-off-by: JahnabDutta <[email protected]>
Signed-off-by: JahnabDutta <[email protected]>
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Aug 30, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

👋 Hi, @JahnabDutta,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

a single pr is already raised for this issue : #6223

@nihal467 nihal467 closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict pull requests with merge conflict needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants