Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Duty doctors and Staff for each Location in a Facility #5370

Closed
wants to merge 1 commit into from
Closed

fix: Duty doctors and Staff for each Location in a Facility #5370

wants to merge 1 commit into from

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Apr 22, 2023 •
edited by ghost
Loading

Bug Fix

WHAT

🤖 Generated by Copilot at ba5bdc4

The pull request adds the feature to assign users (doctors and staff) to locations in a facility and display them in the location management table. It modifies the AddLocationForm.tsx, LocationManagement.tsx, and models.tsx files in the src/Components/Facility folder to handle the user data and the UI components.

Proposed Changes

  • Adds Duty Staff section to location form
  • Stores doctors and staff with each location

Associated Issue

Screenshot

  • Location View table
    image

  • Location Add form
    image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at ba5bdc4

  • Add multi-select dropdown fields for selecting users (doctors and staff) for a location in the AddLocationForm component (link, link, link, link, link, link, link, link, link)
  • Fetch and store the list of users (doctors and staff) associated with a facility using the getFacilityUsers action in the AddLocationForm component (link, link)
  • Extract and store the list of users (doctors and staff) assigned to a location from the API response in the AddLocationForm component (link)
  • Include the duty_staff field in the data object sent to the API when submitting the AddLocationForm component (link, link)
  • Render the list of users (doctors and staff) assigned to a location as badges with icons and names in the LocationRow component (link, link, link)
  • Pass the doctors and staff props to the LocationRow component from the duty_staff_objects field of the locationItem object in the LocationManagement component (link)
  • Add the duty_staff_objects field to the LocationModel interface in the src/Components/Facility/models.ts file (link, link)

@vercel
Copy link

vercel bot commented Apr 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 0:11am

@netlify
Copy link

netlify bot commented Apr 22, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 764d640
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65326e35c8329e000836da20
😎 Deploy Preview https://deploy-preview-5370--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aeswibon aeswibon mentioned this pull request Apr 22, 2023
Closed
3 tasks
@aeswibon aeswibon marked this pull request as ready for review April 22, 2023 17:50
@aeswibon aeswibon requested a review from a team April 22, 2023 17:50
@aeswibon aeswibon requested a review from a team as a code owner April 22, 2023 17:50
@aeswibon aeswibon requested a review from bodhish April 22, 2023 17:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 24, 2023
@github-actions
Copy link

👋 Hi, @cp-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@aeswibon aeswibon removed the merge conflict pull requests with merge conflict label May 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 30, 2023
@github-actions
Copy link

👋 Hi, @cp-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented Aug 2, 2023

@cp-coder resolve the merge conflict

@aeswibon aeswibon removed the merge conflict pull requests with merge conflict label Aug 4, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 16, 2023
@github-actions
Copy link

👋 Hi, @cp-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

@cp-coder can you clear the merge conflict

@aeswibon aeswibon removed the merge conflict pull requests with merge conflict label Sep 30, 2023
@nihal467
Copy link
Member

nihal467 commented Oct 3, 2023

LGTM

@nihal467
Copy link
Member

@gigincg to post a comment on @vigneshhari query in the back-end

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 17, 2023
@github-actions
Copy link

👋 Hi, @cp-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@aeswibon aeswibon removed the merge conflict pull requests with merge conflict label Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 7a8fbf0
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/653043010d78ed00073c1ce5

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Oct 18, 2023
@aeswibon aeswibon removed the Deploy-Failed Deplyment is not showing preview label Oct 20, 2023
@nihal467
Copy link
Member

nihal467 commented Oct 26, 2023 •
edited
Loading

@cp-coder will be creating a new co-related back-end PR for review in two days

CC : @khavinshankar @gigincg

@aeswibon aeswibon mentioned this pull request Oct 27, 2023
Closed
3 tasks
@aeswibon
Copy link
Member Author

Opening a new PR

@aeswibon aeswibon closed this Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
stale waiting for backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duty doctors and Staff for each Location in a Facility
2 participants
@aeswibon @nihal467