From c67ced2d6c2b20803652547a21dbc6a0c59b638c Mon Sep 17 00:00:00 2001
From: Rithvik Nishad <mail@rithviknishad.dev>
Date: Fri, 10 Nov 2023 12:28:31 +0530
Subject: [PATCH 1/2] quick patch: hide not working sort filter (#6577)

---
 src/Components/Facility/LiveFeedScreen.tsx | 67 ----------------------
 1 file changed, 67 deletions(-)

diff --git a/src/Components/Facility/LiveFeedScreen.tsx b/src/Components/Facility/LiveFeedScreen.tsx
index b9a2eabdc03..a47d4a0c955 100644
--- a/src/Components/Facility/LiveFeedScreen.tsx
+++ b/src/Components/Facility/LiveFeedScreen.tsx
@@ -14,9 +14,6 @@ import { AssetData } from "../Assets/AssetTypes";
 import { Popover, Transition } from "@headlessui/react";
 import { FieldLabel } from "../Form/FormFields/FormField";
 import CheckBoxFormField from "../Form/FormFields/CheckBoxFormField";
-import { useTranslation } from "react-i18next";
-import { SortOption } from "../Common/SortDropdown";
-import { SelectFormField } from "../Form/FormFields/SelectFormField";
 import LiveFeedTile from "./LiveFeedTile";
 import { getCameraConfig } from "../../Utils/transformUtils";
 import { getPermittedFacility, listAssets } from "../../Redux/actions";
@@ -24,45 +21,11 @@ import { useDispatch } from "react-redux";
 
 const PER_PAGE_LIMIT = 6;
 
-const SORT_OPTIONS: SortOption[] = [
-  { isAscending: true, value: "bed__name" },
-  { isAscending: false, value: "-bed__name" },
-  { isAscending: false, value: "-created_date" },
-  { isAscending: true, value: "created_date" },
-];
-
 interface Props {
   facilityId: string;
 }
 
-const getOrderingList = async (
-  facilityId: string,
-  setOrdering: (order: string) => void
-) => {
-  const orderData = localStorage.getItem("live-feed-order");
-  if (orderData) {
-    const order = JSON.parse(orderData);
-    const orderValue = order.find((item: any) => item.facility === facilityId);
-    setOrdering(orderValue.order);
-  }
-};
-
-const setOrderingList = async (facilityId: string, order: string) => {
-  const orderData = localStorage.getItem("live-feed-order") || "[]";
-  const orderList = JSON.parse(orderData);
-  const index = orderList.findIndex(
-    (item: any) => item.facility === facilityId
-  );
-  if (index !== -1) {
-    orderList[index].order = order;
-  } else {
-    orderList.push({ facility: facilityId, order });
-  }
-  localStorage.setItem("live-feed-order", JSON.stringify(orderList));
-};
-
 export default function LiveFeedScreen({ facilityId }: Props) {
-  const { t } = useTranslation();
   const dispatch = useDispatch<any>();
   const [isFullscreen, setFullscreen] = useFullscreen();
   const sidebar = useContext(SidebarShrinkContext);
@@ -73,7 +36,6 @@ export default function LiveFeedScreen({ facilityId }: Props) {
   const { qParams, updateQuery, removeFilter, updatePage } = useFilters({
     limit: PER_PAGE_LIMIT,
   });
-  const [ordering, setOrdering] = useState<string>("bed__name");
 
   const [refresh_presets_hash, setRefreshPresetsHash] = useState<number>(
     Number(new Date())
@@ -88,10 +50,6 @@ export default function LiveFeedScreen({ facilityId }: Props) {
     };
   }, []);
 
-  useEffect(() => {
-    getOrderingList(facilityId, setOrdering);
-  }, [facilityId]);
-
   useEffect(() => {
     async function fetchFacilityOrObject() {
       if (facility) return facility;
@@ -112,7 +70,6 @@ export default function LiveFeedScreen({ facilityId }: Props) {
         asset_class: "ONVIF",
         facility: facilityId || "",
         location: qParams.location,
-        ordering: qParams.ordering || ordering,
         bed_is_occupied: qParams.bed_is_occupied,
       };
 
@@ -204,30 +161,6 @@ export default function LiveFeedScreen({ facilityId }: Props) {
                         )}
                       </div>
                     </div>
-                    <SelectFormField
-                      name="ordering"
-                      label={t("sort_by")}
-                      required
-                      value={qParams.ordering || ordering}
-                      onChange={({ value }) => {
-                        updateQuery({ ordering: value });
-                        setOrderingList(facilityId, value);
-                      }}
-                      options={SORT_OPTIONS}
-                      optionLabel={({ value }) => t("SortOptions." + value)}
-                      optionIcon={({ isAscending }) => (
-                        <CareIcon
-                          className={
-                            isAscending
-                              ? "care-l-sort-amount-up"
-                              : "care-l-sort-amount-down"
-                          }
-                        />
-                      )}
-                      optionValue={({ value }) => value}
-                      labelClassName="text-sm"
-                      errorClassName="hidden"
-                    />
                     <CheckBoxFormField
                       name="bed_is_occupied"
                       label="Hide Cameras without Patient"

From 8e2148f4f82bb0e3bb4b54ef8a119ae52eed94ad Mon Sep 17 00:00:00 2001
From: Ashesh <3626859+Ashesh3@users.noreply.github.com>
Date: Fri, 10 Nov 2023 14:37:53 +0530
Subject: [PATCH 2/2] Fix clear button for CNS location filter (#6581)

* Fix clear button for CNS location filter

* Fixes

* tooltip
---
 .../Facility/CentralNursingStation.tsx         | 18 ++++++------------
 src/Components/Facility/FacilityCard.tsx       |  2 +-
 src/Components/Facility/LiveFeedScreen.tsx     | 18 ++++++------------
 3 files changed, 13 insertions(+), 25 deletions(-)

diff --git a/src/Components/Facility/CentralNursingStation.tsx b/src/Components/Facility/CentralNursingStation.tsx
index 26bed83635b..0eae504399c 100644
--- a/src/Components/Facility/CentralNursingStation.tsx
+++ b/src/Components/Facility/CentralNursingStation.tsx
@@ -168,11 +168,15 @@ export default function CentralNursingStation({ facilityId }: Props) {
                       <FieldLabel className="text-sm">
                         Filter by Location
                       </FieldLabel>
-                      <div className="flex w-full items-center gap-2">
+                      <div>
                         <LocationSelect
                           key={qParams.location}
                           name="Facilities"
-                          setSelected={(location) => updateQuery({ location })}
+                          setSelected={(location) => {
+                            location
+                              ? updateQuery({ location })
+                              : removeFilter("location");
+                          }}
                           selected={qParams.location}
                           showAll={false}
                           multiple={false}
@@ -180,16 +184,6 @@ export default function CentralNursingStation({ facilityId }: Props) {
                           errors=""
                           errorClassName="hidden"
                         />
-                        {qParams.location && (
-                          <ButtonV2
-                            variant="secondary"
-                            circle
-                            border
-                            onClick={() => removeFilter("location")}
-                          >
-                            Clear
-                          </ButtonV2>
-                        )}
                       </div>
                     </div>
                     <SelectFormField
diff --git a/src/Components/Facility/FacilityCard.tsx b/src/Components/Facility/FacilityCard.tsx
index a50b3fc985c..ab37ac20c96 100644
--- a/src/Components/Facility/FacilityCard.tsx
+++ b/src/Components/Facility/FacilityCard.tsx
@@ -167,7 +167,7 @@ export const FacilityCard = (props: { facility: any; userType: any }) => {
                             : "button-primary-border bg-primary-100"
                         }`}
                       >
-                        <span className="tooltip-text tooltip-bottom md:tooltip-right -translate-y-2">
+                        <span className="tooltip-text tooltip-top">
                           Live Patients / Total beds
                         </span>{" "}
                         <CareIcon
diff --git a/src/Components/Facility/LiveFeedScreen.tsx b/src/Components/Facility/LiveFeedScreen.tsx
index a47d4a0c955..e744ef404cd 100644
--- a/src/Components/Facility/LiveFeedScreen.tsx
+++ b/src/Components/Facility/LiveFeedScreen.tsx
@@ -137,11 +137,15 @@ export default function LiveFeedScreen({ facilityId }: Props) {
                       <FieldLabel className="text-sm">
                         Filter by Location
                       </FieldLabel>
-                      <div className="flex w-full items-center gap-2">
+                      <div>
                         <LocationSelect
                           key={qParams.location}
                           name="Facilities"
-                          setSelected={(location) => updateQuery({ location })}
+                          setSelected={(location) => {
+                            location
+                              ? updateQuery({ location })
+                              : removeFilter("location");
+                          }}
                           selected={qParams.location}
                           showAll={false}
                           multiple={false}
@@ -149,16 +153,6 @@ export default function LiveFeedScreen({ facilityId }: Props) {
                           errors=""
                           errorClassName="hidden"
                         />
-                        {qParams.location && (
-                          <ButtonV2
-                            variant="secondary"
-                            circle
-                            border
-                            onClick={() => removeFilter("location")}
-                          >
-                            Clear
-                          </ButtonV2>
-                        )}
                       </div>
                     </div>
                     <CheckBoxFormField