From 4bda4c2ca662bce5d4cd906c772854d026b0e1c8 Mon Sep 17 00:00:00 2001
From: sriharsh05 <sriharsh.harsha5@gmail.com>
Date: Thu, 18 Jan 2024 15:30:58 +0530
Subject: [PATCH] replace useDispatch with useQuery/request in minimum quantity
 required modal

---
 .../Facility/MinQuantityRequiredModal.tsx     | 88 ++++++++-----------
 src/Components/Facility/models.tsx            | 18 ++++
 src/Redux/actions.tsx                         | 14 ---
 src/Redux/api.tsx                             |  7 ++
 4 files changed, 63 insertions(+), 64 deletions(-)

diff --git a/src/Components/Facility/MinQuantityRequiredModal.tsx b/src/Components/Facility/MinQuantityRequiredModal.tsx
index 46296545500..1a604e3a66e 100644
--- a/src/Components/Facility/MinQuantityRequiredModal.tsx
+++ b/src/Components/Facility/MinQuantityRequiredModal.tsx
@@ -1,15 +1,11 @@
-import { useCallback, useReducer, useState } from "react";
-import { useDispatch } from "react-redux";
-import { statusType, useAbortableEffect } from "../../Common/utils";
-import {
-  updateMinQuantity,
-  getAnyFacility,
-  getMinQuantityOfItem,
-} from "../../Redux/actions";
+import { useReducer, useState } from "react";
 import * as Notification from "../../Utils/Notifications.js";
 import ButtonV2 from "../Common/components/ButtonV2";
 import DialogModal from "../Common/Dialog";
 import TextFormField from "../Form/FormFields/TextFormField";
+import useQuery from "../../Utils/request/useQuery";
+import routes from "../../Redux/api";
+import request from "../../Utils/request/request";
 
 const initForm = {
   id: "",
@@ -42,56 +38,47 @@ export const MinQuantityRequiredModal = (props: any) => {
   const [state, dispatch] = useReducer(inventoryFormReducer, initialState);
   const { facilityId, inventoryId, itemId, show, handleClose, handleUpdate } =
     props;
-  const dispatchAction: any = useDispatch();
-  const [isLoading, setIsLoading] = useState(false);
-  const [data, setData] = useState(" ");
-  const [facilityName, setFacilityName] = useState("");
+  const [isLoading, setIsLoading] = useState(true);
 
-  const fetchData = useCallback(
-    async (status: statusType) => {
-      setIsLoading(true);
-      const res = await dispatchAction(
-        getMinQuantityOfItem(facilityId, inventoryId)
-      );
-      if (!status.aborted) {
-        if (res && res.data) {
-          setData(res.data.item_object.name);
-          const form = { ...state.form, quantity: res.data.min_quantity };
+  const { data: minimumQuantityItemData } = useQuery(
+    routes.getMinQuantityItem,
+    {
+      pathParams: {
+        facilityId,
+        inventoryId,
+      },
+      prefetch: !!facilityId && !!inventoryId,
+      onResponse: async ({ res, data }) => {
+        setIsLoading(true);
+        if (res?.ok && data) {
+          const form = { ...state.form, quantity: data.min_quantity };
           dispatch({ type: "set_form", form });
         }
-        if (facilityId) {
-          const res = await dispatchAction(getAnyFacility(facilityId));
-
-          setFacilityName(res?.data?.name || "");
-        } else {
-          setFacilityName("");
-        }
-
         setIsLoading(false);
-      }
-    },
-    [dispatchAction, facilityId, inventoryId]
-  );
-  useAbortableEffect(
-    (status: statusType) => {
-      fetchData(status);
-    },
-    [fetchData]
+      },
+    }
   );
 
+  const { data: facilityObject } = useQuery(routes.getAnyFacility, {
+    pathParams: { id: facilityId },
+    prefetch: !!facilityId,
+  });
+
   const handleSubmit = async (e: any) => {
     e.preventDefault();
     setIsLoading(true);
-    const data: any = {
-      min_quantity: Number(state.form.quantity),
-      item: Number(itemId),
-    };
-
-    const res = await dispatchAction(
-      updateMinQuantity(data, { facilityId, inventoryId })
-    );
+    const { res, data } = await request(routes.updateMinQuantity, {
+      pathParams: {
+        facilityId,
+        inventoryId,
+      },
+      body: {
+        min_quantity: Number(state.form.quantity),
+        item: Number(itemId),
+      },
+    });
     setIsLoading(false);
-    if (res && res.data) {
+    if (res?.ok && data) {
       Notification.Success({
         msg: "Minimum quantity updated successfully",
       });
@@ -138,8 +125,9 @@ export const MinQuantityRequiredModal = (props: any) => {
           {" "}
           <div className="mb-4">
             <p className="mt-1 text-sm text-gray-500">
-              Set the minimum quantity for <strong>{data}</strong> in{" "}
-              <strong> {facilityName}</strong>
+              Set the minimum quantity for{" "}
+              <strong>{minimumQuantityItemData?.item_object.name}</strong> in{" "}
+              <strong> {facilityObject?.name}</strong>
             </p>
           </div>
           <div className="mb-4">
diff --git a/src/Components/Facility/models.tsx b/src/Components/Facility/models.tsx
index 6a60b6993d0..f8a57fa7c8e 100644
--- a/src/Components/Facility/models.tsx
+++ b/src/Components/Facility/models.tsx
@@ -554,3 +554,21 @@ export type InventorySummaryResponse = {
   is_low: boolean;
   item: number;
 };
+
+// export type InventoryLogResponse = InventorySummaryResponse & {
+//   external_id: string;
+//   current_stock: number;
+//   quantity_in_default_unit: number;
+//   is_incoming: boolean;
+//   probable_accident: boolean;
+//   unit: number;
+//   created_by: number;
+// };
+
+export type MinimumQuantityItemResponse = {
+  id: string;
+  item_object: InventoryItemsModel;
+  created_date: string;
+  min_quantity: number;
+  item: number;
+};
diff --git a/src/Redux/actions.tsx b/src/Redux/actions.tsx
index d6de3c3b960..62a2416d36c 100644
--- a/src/Redux/actions.tsx
+++ b/src/Redux/actions.tsx
@@ -282,20 +282,6 @@ export const getMinQuantity = (facilityId: object, params: object) => {
   return fireRequest("getMinQuantity", [facilityId, "min_quantity"], params);
 };
 
-export const getMinQuantityOfItem = (
-  facilityId: object,
-  externalId: object
-) => {
-  return fireRequest("getMinQuantity", [
-    facilityId,
-    "min_quantity",
-    externalId,
-  ]);
-};
-
-export const updateMinQuantity = (pathParams: object, params: object) => {
-  return fireRequest("updateMinQuantity", [], pathParams, params);
-};
 export const getInventorySummary = (facilityId: number, params: object) => {
   return fireRequest(
     "getInventorySummary",
diff --git a/src/Redux/api.tsx b/src/Redux/api.tsx
index ff2ae8c2355..d56961c0eef 100644
--- a/src/Redux/api.tsx
+++ b/src/Redux/api.tsx
@@ -52,6 +52,7 @@ import {
   PatientNotesModel,
   BedModel,
   InventorySummaryResponse,
+  MinimumQuantityItemResponse,
 } from "../Components/Facility/models";
 import {
   IDeleteBedCapacity,
@@ -794,9 +795,15 @@ const routes = {
     method: "GET",
     TRes: Type<PaginatedResponse<InventorySummaryResponse>>(),
   },
+  getMinQuantityItem: {
+    path: "/api/v1/facility/{facilityId}/min_quantity/{inventoryId}",
+    method: "GET",
+    TRes: Type<MinimumQuantityItemResponse>(),
+  },
   updateMinQuantity: {
     path: "/api/v1/facility/{facilityId}/min_quantity/{inventoryId}",
     method: "PATCH",
+    TRes: Type<PaginatedResponse<MinimumQuantityItemResponse>>(),
   },
   getInventorySummary: {
     path: "/api/v1/facility",