-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boundary based validation #1453
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JahnabDutta <[email protected]>
Signed-off-by: JahnabDutta <[email protected]>
Signed-off-by: JahnabDutta <[email protected]>
Signed-off-by: JahnabDutta <[email protected]>
sainak
requested changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert changes on non-relevant files
Signed-off-by: JahnabDutta <[email protected]>
…care into add-boundary-preset
JahnabDutta
commented
Aug 23, 2023
JahnabDutta
commented
Aug 23, 2023
unused variables and simplify code
test_asset_operate_api.py
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1453 +/- ##
==========================================
+ Coverage 60.43% 60.75% +0.32%
==========================================
Files 210 210
Lines 11473 11493 +20
Branches 1630 1634 +4
==========================================
+ Hits 6934 6983 +49
+ Misses 4307 4268 -39
- Partials 232 242 +10 ☔ View full report in Codecov by Sentry. |
6 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
/opearate_asset
api to contain id of boundary-AssetBed realated to the given AssetBed and current CameraState.validate_action
inOnvifAsset
to validate and kind ofrelativeMove
, if the movement is within the range.handle_action
inOnvifAsset
to ensure additional parameters in the request body do not affect thehandle_action
function.validate_action
in other asset integration modules for future useAssociated Issue
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins