Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixes.js is not very robust (this may be policy as much as code) #19

Open
DILewis opened this issue Dec 7, 2022 · 0 comments
Open

Comments

@DILewis
Copy link
Contributor

DILewis commented Dec 7, 2022

The prefixes.js file sets up an object which associates prefixes with URL expansions to make typing and reading URLs in the code easier. This is declared as const.
A few observations:

  • Individual apps may also need extra prefixes. These don't have to be added to a central object, but that might be useful
  • Apps may rely on these expansions, so, e.g. we should probably prefer adding entries rather than changing http->https so that existing prefixes continue to provide backward compatibility
  • Perhaps we can place these somewhere where they are easier to include

Note on motivation of this issue: We have, in the Beethoven in the House project an example where the traverser has been encapsulated within Vue native objects. In this use case, the devs felt it was easier and more robust to duplicate the prefix object and then extend it. This prompted discussion of what good, sustainable practice would be and how we could support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant