Add documentation on updating Octue services #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thclark
requested changes
Oct 24, 2024
docs/source/updating_services.rst
Outdated
|
|
||
| 6. Write any new tests you need to verify your code works and update any old tests as needed | ||
|
|
||
| 7. Run the tests locally using e.g. ``pytest`` or ``python -m unittest`` |
There was a problem hiding this comment.
Consolidate on pytest. It should be in a code block so it gets formatted similarly to previous steps.
Note: we should start installing it as a dev dependency by default.
There was a problem hiding this comment.
oooh double note, we should have a pytest-octue module containing all our test code ;)
There was a problem hiding this comment.
you could have a screenshot of pytest output in the terminal, you want all green ticks ;)
There was a problem hiding this comment.
Do you mean test code for the SDK or some kind of generalisable test helpers?
There was a problem hiding this comment.
I've got a screenshot from amy - I think that's ok? It doesn't reveal anything private apart from test paths
skipci
thclark
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents (#683)
Operations
ruffpre-commit checkDependencies
ruffto dev dependenciesOther