-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make event handling faster and resilient to missing events #625
Merged
cortadocodes
merged 40 commits into
main
from
improve-questions-asking-and-event-handling
Feb 5, 2024
Merged
Make event handling faster and resilient to missing events #625
cortadocodes
merged 40 commits into
main
from
improve-questions-asking-and-event-handling
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
==========================================
- Coverage 94.90% 94.86% -0.04%
==========================================
Files 77 77
Lines 3394 3409 +15
==========================================
+ Hits 3221 3234 +13
- Misses 173 175 +2 ☔ View full report in Codecov by Sentry. |
BREAKING CHANGE: This removes the `service_name` argument from `Service.wait_for_answer`. If you were using this argument, simply remove it; logs from children shown in a parent will now have the full and correct SRUID automatically.
skipci
cortadocodes
changed the title
Improve questions asking and event handling
Make event handling faster and resilient to missing events
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents (#625)
IMPORTANT: There is 1 breaking change.
Enhancements
Child.ask_multiple
OrderedMessageHandler
Fixes
Manifest.update_dataset_paths
method thread-safeRefactoring
Testing
_pull_and_enqueue_available_messages
method and removingMockMessagePuller
Upgrade instructions
💥 Extract SRUID for child logs from subscription in message handler
This removes the
service_name
argument fromService.wait_for_answer
. If you were using this argument, simply remove it; logs from children shown in a parent will now have the full and correct SRUID automatically.