Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pull request number instead of branch name for branch deployments #12

Open
cortadocodes opened this issue Dec 1, 2023 · 2 comments
Assignees

Comments

@cortadocodes
Copy link
Member

cortadocodes commented Dec 1, 2023

Bug report

What is the current behavior?

Many branch names are longer than the limit set by Google Cloud Run for service names when they're used as the revision tag, which makes deployment fail. We have to manually truncate branches in workflows that use this action to make up for it.

What is the expected behavior?

No truncation is needed and branch deployments just work.

@cortadocodes cortadocodes self-assigned this Dec 1, 2023
@cortadocodes cortadocodes moved this to Priority 3 (High) in Octue Board Dec 1, 2023
@cortadocodes
Copy link
Member Author

We may not need this because:

  • Workflows triggered by pull requests are already in a short enough form that uses pull request number
  • We can restrict push triggers to only run on main
  • We might opt to replace automatic pull request triggers with manual workflow dispatches where the user can choose the revision tag

@thclark
Copy link
Contributor

thclark commented Feb 6, 2024

It wouldn't hurt to simply add a pr_number to the outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Priority 3 (High)
Development

No branches or pull requests

2 participants