Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor remains editable in readonly mode #14

Open
thclark opened this issue Dec 20, 2023 · 0 comments
Open

Editor remains editable in readonly mode #14

thclark opened this issue Dec 20, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@thclark
Copy link
Contributor

thclark commented Dec 20, 2023

Bug report

What's happening

The json is still editable when widgets are rendered as read-only in the admin (eg for fields where editable=false).

Cause

In the props passed to the component, props can now be customised, so a readOnly prop is acceptable. But, its value isn't determined; it must be set explicitly on the widget or in settings.

The admin governs whether a widget should be readonly or not. So, the readOnly prop (see editor customizable properties) should determined, rather than treated as a customizable option.

@thclark thclark added the bug Something isn't working label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants