Allow expect_tests to be DCE by jsoo .. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when setting FORCE_DROP_INLINE_TEST
github-iron
added
the
forwarded-to-js-devs
|
gentle ping |
|
Has anyone looked at this ? |
|
@TyOverby, can you try to move this forward ? |
|
Sorry, It looks like no one noticed this earlier, I've forwarded it to the owners of this library |
|
Thanks for the report, and sorry that this got lost internally. We'll need to make this change using the interface exposed by the |
|
Any progress ? |
|
I took this over from @dvulakh yesterday and it should be ready soon. Sorry for how long this has taken |
|
the fix has been released and will be included in our next push to github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when setting FORCE_DROP_INLINE_TEST
This fixes ocsigen/js_of_ocaml#1625.
I'm not attached to the current implementation. In particular, one could share the logic with ppx_inline_test. I let you decide what to do.
cc @WardBrian