Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constraints on package versions in conflicts, it's unsupported #23736

Merged
merged 1 commit into from
May 31, 2023

Conversation

Leonidas-from-XIV
Copy link
Contributor

After a debugging session with @kit-ty-kate as part of fixing tarides/opam-monorepo#349 and ocaml-opam/opam-0install-solver#46 we realized that OPAM doesn't support resolving package variables in conflicts fields (the linter complains about this in depends fileds but not in conflicts fields, but the solver never resolves these variables). So this constraint doesn't do anything in OPAM and it causes issues in the opam-0install-solver which attempts to resolve them.

After a debugging session with @kit-ty-kate as part of fixing
tarides/opam-monorepo#349 and
ocaml-opam/opam-0install-solver#46 we realized
that OPAM doesn't support resolving package variables in `conflicts`
fields (the linter complains about this in `depends` fileds but not in
`conflicts` fields, but the solver never resolves these variables). So
this constraint doesn't do anything in OPAM and it causes issues in the
opam-0install-solver which attempts to resolve them.
@mseri
Copy link
Member

mseri commented May 7, 2023

@kit-ty-kate can we merge this or we should wait to avoid triggering rebuilds?

@tmcgilchrist
Copy link
Contributor

The package linting is pointing out that some fields are missing.

2023-05-12 23:30.49: Error in ocaml-options-vanilla.1:            warning 68: Missing field 'license'
2023-05-12 23:30.49: Error in ocaml-options-vanilla.1:            warning 36: Missing field 'bug-reports'
2023-05-12 23:30.49: Error in ocaml-options-vanilla.1:            warning 35: Missing field 'homepage'
2023-05-12 23:30.49: Error in ocaml-options-vanilla.1:            warning 25: Missing field 'authors'

@Leonidas-from-XIV
Copy link
Contributor Author

@tmcgilchrist None of the ocaml-options-* packages has these fields, should I add them to all of them?

@mseri
Copy link
Member

mseri commented May 15, 2023

No need to make any other changes. The ocaml-options packages are special in that respect, they only turn on or off flags in the ocaml compiler packages and mark mutual incompatibilities. You can ignore these warnings and errors in this case.

For compiler packaes, we wait for thumbs up from compiler maintainers and if there is a risk of retriggering builds in many switches for non-critical changes, we wait for a release and bulk together the merge of the compiler changes.

@avsm
Copy link
Member

avsm commented May 31, 2023

Lets go ahead and get this in, as it's a violation of the opam format spec.

@avsm avsm merged commit c2772f0 into ocaml:master May 31, 2023
@Leonidas-from-XIV Leonidas-from-XIV deleted the no-version-constraints branch May 31, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants