Update ocaml/setup-ocaml to v3 #1153
Conversation
|
If I understand correctly the setup-ocaml release changelog, this setups ocaml with opam 2.2 for windows support? |
|
I added Windows, but it seems to fail due to the path delimiter, etc. |
|
You shouldn't use Fpath.to_string when generating path in dune files. |
There was a problem hiding this comment.
I think we are not ready yet to add windows testing on our CI. However, it is very nice to be able to add it so easily!
I think this is good to merge as soon as the windows-triggering line is commented out. We'll uncomment it after fixing the windows issues.
Thanks a lot for your work!
smorimoto
force-pushed
the
setup-ocaml-v3
branch
3 times, most recently
from
f3a8433
to
4c9d7e8
Compare
|
Ready to go! |
smorimoto
force-pushed
the
setup-ocaml-v3
branch
2 times, most recently
from
2d04875
to
1785c88
Compare
Signed-off-by: Sora Morimoto <[email protected]>
|
@panglesd Ready to go! |
smorimoto
force-pushed
the
setup-ocaml-v3
branch
from
1785c88
to
b18b4d6
Compare
Until we have a plan to fix the tests on windows, there is no point in running the tests on Windows just to ignore them.
|
Thanks! I commented the windows matrix entry: We don't have a plan to fix the tests on windows in the (very) short term, there is no point in running them just to ignore them. But thanks to you, they are now very easy to add as soon as we start working on them! |
|
OK! |
No description provided.